third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py - Issue 2781733003: Improve run-webkit-tests error reporting when ref tests have missing images.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py

Issue 2781733003: Improve run-webkit-tests error reporting when ref tests have missing images. (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py » ('j') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py

index 1804e079dd779904893699c669a31dff88933a8e..4e609df45a9c59da119e6d70fc2b117c025eddeb 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py

@@ -458,8 +458,10 @@ class SingleTestRunner(object):

if failures:

return TestResult(self._test_name, failures, 0, has_stderr, pid=actual_driver_output.pid)

- if not reference_driver_output.image_hash and not actual_driver_output.image_hash:

- failures.append(test_failures.FailureReftestNoImagesGenerated(reference_filename))

+ if not actual_driver_output.image_hash:

+ failures.append(test_failures.FailureReftestNoImageGenerated(reference_filename))

+ elif not reference_driver_output.image_hash:

+ failures.append(test_failures.FailureReftestNoReferenceImageGenerated(reference_filename))

elif mismatch:

if reference_driver_output.image_hash == actual_driver_output.image_hash:

failures.append(test_failures.FailureReftestMismatchDidNotOccur(reference_filename))