Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 2781733002: Enable transparency when dragging from the omnibox (Closed)

Created:
3 years, 9 months ago by Tom (Use chromium acct)
Modified:
3 years, 7 months ago
Reviewers:
sadrul
CC:
chromium-reviews, yusukes+watch_chromium.org, derat+watch_chromium.org, tfarina, shuchen+watch_chromium.org, dcheng, nona+watch_chromium.org, James Su
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable transparency when dragging from the omnibox Previously, dragging text out of the omnibox would render with a solid background on Linux because transparency wasn't available. However, after https://codereview.chromium.org/2347383002/, transparency is enabled. This CL enables transparency on text dragged out of the omnibox on Linux. In addition, when dragging ALL text from the omnibox, a special URL drag window with some text and an icon is used instead. Transparency was previously not enabled on this window because DWTHX11::IsTranslucentWindowOpacitySupported() was returning the wrong value. R=sadrul@chromium.org Review-Url: https://codereview.chromium.org/2781733002 Cr-Commit-Position: refs/heads/master@{#470092} Committed: https://chromium.googlesource.com/chromium/src/+/5785866a9b2a0db4854552eb87af7229d4b11a43

Patch Set 1 #

Patch Set 2 : Add nogncheck #

Patch Set 3 : Fix CrOS build #

Total comments: 5

Patch Set 4 : const #

Patch Set 5 : Revert button_drag_utils #

Total comments: 5

Patch Set 6 : Add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -14 lines) Patch
M ui/base/x/x11_util.cc View 1 2 3 4 5 4 chunks +6 lines, -6 lines 0 comments Download
M ui/base/x/x11_util_internal.h View 1 2 3 3 chunks +3 lines, -2 lines 0 comments Download
M ui/views/controls/textfield/textfield.cc View 1 2 3 4 5 2 chunks +8 lines, -4 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 1 2 3 4 5 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 50 (35 generated)
Tom (Use chromium acct)
sadrul ptal
3 years, 9 months ago (2017-03-27 20:54:35 UTC) #2
sadrul
https://codereview.chromium.org/2781733002/diff/40001/ui/base/x/x11_util_internal.h File ui/base/x/x11_util_internal.h (right): https://codereview.chromium.org/2781733002/diff/40001/ui/base/x/x11_util_internal.h#newcode82 ui/base/x/x11_util_internal.h:82: bool ArgbVisualAvailable(); const method https://codereview.chromium.org/2781733002/diff/40001/ui/views/button_drag_utils.cc File ui/views/button_drag_utils.cc (left): https://codereview.chromium.org/2781733002/diff/40001/ui/views/button_drag_utils.cc#oldcode59 ...
3 years, 8 months ago (2017-03-28 15:52:08 UTC) #15
Tom (Use chromium acct)
https://codereview.chromium.org/2781733002/diff/40001/ui/base/x/x11_util_internal.h File ui/base/x/x11_util_internal.h (right): https://codereview.chromium.org/2781733002/diff/40001/ui/base/x/x11_util_internal.h#newcode82 ui/base/x/x11_util_internal.h:82: bool ArgbVisualAvailable(); On 2017/03/28 15:52:07, sadrul wrote: > const ...
3 years, 8 months ago (2017-03-28 18:28:10 UTC) #17
sadrul
https://codereview.chromium.org/2781733002/diff/40001/ui/views/button_drag_utils.cc File ui/views/button_drag_utils.cc (left): https://codereview.chromium.org/2781733002/diff/40001/ui/views/button_drag_utils.cc#oldcode59 ui/views/button_drag_utils.cc:59: ui::NativeTheme::kColorId_TextfieldDefaultBackground); On 2017/03/28 18:28:10, Tom Anderson wrote: > On ...
3 years, 8 months ago (2017-03-28 18:52:40 UTC) #20
Tom (Use chromium acct)
On 2017/03/28 18:52:40, sadrul wrote: > https://codereview.chromium.org/2781733002/diff/40001/ui/views/button_drag_utils.cc > File ui/views/button_drag_utils.cc (left): > > https://codereview.chromium.org/2781733002/diff/40001/ui/views/button_drag_utils.cc#oldcode59 > ...
3 years, 8 months ago (2017-03-28 20:31:27 UTC) #24
sadrul
https://codereview.chromium.org/2781733002/diff/80001/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc File ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc (right): https://codereview.chromium.org/2781733002/diff/80001/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc#newcode1177 ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc:1177: return ui::XVisualManager::GetInstance()->ArgbVisualAvailable(); Here's my understanding of the code: |use_argb_visual_| ...
3 years, 8 months ago (2017-03-29 19:51:04 UTC) #37
Tom (Use chromium acct)
https://codereview.chromium.org/2781733002/diff/80001/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc File ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc (right): https://codereview.chromium.org/2781733002/diff/80001/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc#newcode1177 ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc:1177: return ui::XVisualManager::GetInstance()->ArgbVisualAvailable(); On 2017/03/29 19:51:03, sadrul wrote: > Here's ...
3 years, 8 months ago (2017-03-29 21:09:22 UTC) #38
Tom (Use chromium acct)
https://codereview.chromium.org/2781733002/diff/80001/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc File ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc (right): https://codereview.chromium.org/2781733002/diff/80001/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc#newcode1177 ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc:1177: return ui::XVisualManager::GetInstance()->ArgbVisualAvailable(); On 2017/03/29 21:09:22, Tom Anderson wrote: > ...
3 years, 8 months ago (2017-03-29 21:11:23 UTC) #39
Tom (Use chromium acct)
ping
3 years, 8 months ago (2017-04-17 17:06:48 UTC) #40
sadrul
On 2017/03/29 21:11:23, Tom Anderson wrote: > https://codereview.chromium.org/2781733002/diff/80001/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc > File ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc (right): > > https://codereview.chromium.org/2781733002/diff/80001/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc#newcode1177 ...
3 years, 8 months ago (2017-04-18 17:29:28 UTC) #41
Tom (Use chromium acct)
On 2017/04/18 17:29:28, sadrul wrote: > On 2017/03/29 21:11:23, Tom Anderson wrote: > > > ...
3 years, 7 months ago (2017-05-04 21:23:06 UTC) #42
sadrul
lgtm https://codereview.chromium.org/2781733002/diff/80001/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc File ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc (right): https://codereview.chromium.org/2781733002/diff/80001/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc#newcode1177 ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc:1177: return ui::XVisualManager::GetInstance()->ArgbVisualAvailable(); On 2017/03/29 21:11:23, Tom Anderson wrote: ...
3 years, 7 months ago (2017-05-08 15:27:04 UTC) #43
Tom (Use chromium acct)
https://codereview.chromium.org/2781733002/diff/80001/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc File ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc (right): https://codereview.chromium.org/2781733002/diff/80001/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc#newcode1177 ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc:1177: return ui::XVisualManager::GetInstance()->ArgbVisualAvailable(); On 2017/05/08 15:27:04, sadrul wrote: > On ...
3 years, 7 months ago (2017-05-08 18:04:49 UTC) #44
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2781733002/100001
3 years, 7 months ago (2017-05-08 18:06:00 UTC) #47
commit-bot: I haz the power
3 years, 7 months ago (2017-05-08 19:59:14 UTC) #50
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/5785866a9b2a0db4854552eb87af...

Powered by Google App Engine
This is Rietveld 408576698