Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: content/browser/web_contents/web_contents_view_aura_browsertest.cc

Issue 278173005: Removing listening for repaints (OnUpdateRect) from OverscrollNavigationOverlay. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/web_contents/aura/overscroll_navigation_overlay_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/web_contents/web_contents_view_aura_browsertest.cc
diff --git a/content/browser/web_contents/web_contents_view_aura_browsertest.cc b/content/browser/web_contents/web_contents_view_aura_browsertest.cc
index 330f624685b00f9f3ec4a9546c72edd1784e7983..9d45073a5cbdc18f643d424a75c7042af342f6f5 100644
--- a/content/browser/web_contents/web_contents_view_aura_browsertest.cc
+++ b/content/browser/web_contents/web_contents_view_aura_browsertest.cc
@@ -17,12 +17,14 @@
#include "content/browser/frame_host/navigation_entry_screenshot_manager.h"
#include "content/browser/web_contents/web_contents_impl.h"
#include "content/browser/web_contents/web_contents_view.h"
+#include "content/common/view_messages.h"
#include "content/public/browser/render_frame_host.h"
#include "content/public/browser/web_contents_observer.h"
#include "content/public/common/content_switches.h"
#include "content/public/test/browser_test_utils.h"
#include "content/public/test/content_browser_test.h"
#include "content/public/test/content_browser_test_utils.h"
+#include "content/public/test/test_renderer_host.h"
#include "content/public/test/test_utils.h"
#include "content/shell/browser/shell.h"
#include "ui/aura/test/event_generator.h"
@@ -206,6 +208,12 @@ class WebContentsViewAuraTest : public ContentBrowserTest {
EXPECT_TRUE(controller.CanGoForward());
}
+ // Generate DidFirstVisuallyNonEmptyPaint message in order to have the
+ // overscroll overlay dismissed.
+ RenderViewHost* rvh = web_contents->GetRenderViewHost();
+ ViewHostMsg_DidFirstVisuallyNonEmptyPaint msg(rvh->GetRoutingID());
+ RenderViewHostTester::TestOnMessageReceived(rvh, msg);
mfomitchev 2014/05/14 17:46:35 It would be much better if we could actually enabl
+
{
// Do a fling-right now. That should navigate backwards.
base::string16 expected_title = base::ASCIIToUTF16("Title:");
@@ -224,6 +232,11 @@ class WebContentsViewAuraTest : public ContentBrowserTest {
EXPECT_TRUE(controller.CanGoForward());
}
+ // Generate DidFirstVisuallyNonEmptyPaint message in order to have the
+ // overscroll overlay dismissed.
+ ViewHostMsg_DidFirstVisuallyNonEmptyPaint msg2(rvh->GetRoutingID());
+ RenderViewHostTester::TestOnMessageReceived(rvh, msg2);
+
{
// Do a swipe-left now. That should navigate forward.
base::string16 expected_title = base::ASCIIToUTF16("Title: #1");
« no previous file with comments | « content/browser/web_contents/aura/overscroll_navigation_overlay_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698