Removing listening for repaints (OnUpdateRect) from OverscrollNavigationOverlay.

content/browser/web_contents/aura/overscroll_navigation_overlay.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_WEB_CONTENTS_AURA_OVERSCROLL_NAVIGATION_OVERLAY_H_
 #define CONTENT_BROWSER_WEB_CONTENTS_AURA_OVERSCROLL_NAVIGATION_OVERLAY_H_
 
 #include "base/gtest_prod_util.h"
 #include "base/macros.h"
 #include "content/browser/web_contents/aura/window_slider.h"
@@ skipping 30 matching lines @@
   // otherwise the overlay may be dismissed prematurely.
   void StartObserving();
 
   // Sets the screenshot window and the delegate. This takes ownership of
   // |window|.
   // Note that ImageWindowDelegate manages its own lifetime, so this function
   // does not take ownership of |delegate|.
   void SetOverlayWindow(scoped_ptr<aura::Window> window,
                         ImageWindowDelegate* delegate);
 
-  // Sets up the overlay for tests.
-  void SetupForTesting();
-
  private:
   friend class OverscrollNavigationOverlayTest;
   FRIEND_TEST_ALL_PREFIXES(OverscrollNavigationOverlayTest,
                            FirstVisuallyNonEmptyPaint_NoImage);
   FRIEND_TEST_ALL_PREFIXES(OverscrollNavigationOverlayTest,
                            FirstVisuallyNonEmptyPaint_WithImage);
   FRIEND_TEST_ALL_PREFIXES(OverscrollNavigationOverlayTest,
-                           PaintUpdateWithoutNonEmptyPaint);
+                           LoadUpdateWithoutNonEmptyPaint);
   FRIEND_TEST_ALL_PREFIXES(OverscrollNavigationOverlayTest,
                            MultiNavigation_LoadingUpdate);
   FRIEND_TEST_ALL_PREFIXES(OverscrollNavigationOverlayTest,
                            MultiNavigation_PaintUpdate);
 
   enum SlideDirection {
     SLIDE_UNKNOWN,
     SLIDE_BACK,
     SLIDE_FRONT
   };
 
   // Stop observing the page and start the final overlay fade-out animation
-  // if the page-load has completed and the page has been painted, and a
+  // if the the page has been painted or the page-load has completed, and a

[sadrul, 2014/05/27 16:48:29]

s/the the/the/

[mfomitchev, 2014/05/27 21:21:05]

Done.

   // window-slide isn't in progress.
   void StopObservingIfDone();
 
   // Creates a layer to be used for window-slide. |offset| is the offset of the
   // NavigationEntry for the screenshot image to display.
   ui::Layer* CreateSlideLayer(int offset);
 
-  // IPC message callbacks.
-  void OnUpdateRect(const ViewHostMsg_UpdateRect_Params& params);
-
   // Overridden from WindowSlider::Delegate:
   virtual ui::Layer* CreateBackLayer() OVERRIDE;
   virtual ui::Layer* CreateFrontLayer() OVERRIDE;
   virtual void OnWindowSlideCompleting() OVERRIDE;
-  virtual void OnWindowSlideCompleted() OVERRIDE;
+  virtual void OnWindowSlideCompleted(scoped_ptr<ui::Layer> layer) OVERRIDE;
   virtual void OnWindowSlideAborted() OVERRIDE;
   virtual void OnWindowSliderDestroyed() OVERRIDE;
 
   // Overridden from WebContentsObserver:
-  virtual void DocumentOnLoadCompletedInMainFrame() OVERRIDE;
   virtual void DidFirstVisuallyNonEmptyPaint() OVERRIDE;
   virtual void DidStopLoading(RenderViewHost* host) OVERRIDE;
-  virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
 
   // The WebContents which is being navigated.
   WebContentsImpl* web_contents_;
 
   // The screenshot overlay window.
   scoped_ptr<aura::Window> window_;
 
   // This is the WindowDelegate of |window_|. The delegate manages its own
   // lifetime (destroys itself when |window_| is destroyed).
   ImageWindowDelegate* image_delegate_;
 
   bool loading_complete_;
   bool received_paint_update_;
 
   // Unique ID of the NavigationEntry we are navigating to. This is needed to
   // filter on WebContentsObserver callbacks and is used to dismiss the overlay
   // when the relevant page loads and paints.
   int pending_entry_id_;
 
   // The |WindowSlider| that allows sliding history layers while the page is
   // being reloaded.
   scoped_ptr<WindowSlider> window_slider_;
 
+  // Layer to be used for the final overlay fadeout animation when the overlay
+  // is being dismissed.
+  scoped_ptr<ui::Layer> overlay_dismiss_layer_;
+
   // The direction of the in-progress slide (if any).
   SlideDirection slide_direction_;
 
   // The LayerDelegate used for the back/front layers during a slide.
   scoped_ptr<ImageLayerDelegate> layer_delegate_;
 
-  // During tests, the aura windows don't get any paint updates. So the overlay
-  // container keeps waiting for a paint update it never receives, causing a
-  // timeout. So during tests, disable the wait for paint updates.
-  bool need_paint_update_;
-
   DISALLOW_COPY_AND_ASSIGN(OverscrollNavigationOverlay);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_WEB_CONTENTS_AURA_OVERSCROLL_NAVIGATION_OVERLAY_H_