Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 278173004: Clean up the list of dependencies for surface target. (Closed)

Created:
6 years, 7 months ago by tfarina
Modified:
6 years, 7 months ago
Reviewers:
piman
CC:
chromium-reviews, brettw
Visibility:
Public.

Description

Clean up the list of dependencies for surface target. To verify it I ran the following command line: $ g grep -h "#include \"" ui/surface/ | sort | uniq Removing unused dependencies will help when converting this target to GN, specially since media is not yet ported. BUG=None TEST=still links + green trybots R=piman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270895

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -11 lines) Patch
M ui/surface/surface.gyp View 2 chunks +7 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tfarina
Hi Antonie, could you review this to me? Thanks,
6 years, 7 months ago (2014-05-11 00:01:40 UTC) #1
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 7 months ago (2014-05-11 05:21:31 UTC) #2
tfarina
The CQ bit was unchecked by tfarina@chromium.org
6 years, 7 months ago (2014-05-11 05:21:36 UTC) #3
piman
lgtm
6 years, 7 months ago (2014-05-12 19:00:40 UTC) #4
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 7 months ago (2014-05-15 22:41:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/278173004/1
6 years, 7 months ago (2014-05-15 22:43:00 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-16 01:40:13 UTC) #7
Message was sent while issue was closed.
Change committed as 270895

Powered by Google App Engine
This is Rietveld 408576698