third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp - Issue 2781713003: Enable module scripts in ScriptLoader

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp

Issue 2781713003: Enable module scripts in ScriptLoader (Closed)

Patch Set: Rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/dom/ScriptLoader.cpp ('K') | « third_party/WebKit/Source/core/dom/ScriptLoader.cpp ('k') | third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp » ('j') | third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp

diff --git a/third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp b/third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp

index 2af3c5671058a53f6d4bab996c92077797fe3a7c..5065906d52568acc379ecd5665fe620c1dcaab33 100644

--- a/third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp

+++ b/third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp

@@ -291,6 +291,7 @@ void FetchBlockedDocWriteScript(ScriptElementBase* element,

DCHECK(script_loader);

script_loader->SetFetchDocWrittenScriptDeferIdle();

script_loader->PrepareScript(script_start_position);

+ CHECK_EQ(script_loader->GetScriptType(), ScriptType::kClassic);

}

void EmitWarningForDocWriteScripts(const String& url, Document& document) {