Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Unified Diff: third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp

Issue 2781713003: Enable module scripts in ScriptLoader (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp
diff --git a/third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp b/third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp
index 8b0333862476cec082761daa0de4bb30b8d60ee0..ac3ac3960489ca0fb3f186ef3c65d6aec7de4eba 100644
--- a/third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp
+++ b/third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp
@@ -1118,6 +1118,9 @@ void XMLDocumentParser::EndElementNs() {
// FIXME: Script execution should be shared between
// the libxml2 and Qt XMLDocumentParser implementations.
+ // XMLDocumentParser does not support module scripts.
+ CHECK_EQ(script_loader->GetScriptType(), ScriptType::kClassic);
+
if (script_loader->ReadyToBeParserExecuted()) {
if (!script_loader->ExecuteScript(ClassicScript::Create(ScriptSourceCode(
script_loader->ScriptContent(), GetDocument()->Url(),

Powered by Google App Engine
This is Rietveld 408576698