Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(732)

Unified Diff: third_party/WebKit/Source/core/loader/modulescript/ModuleTreeLinker.cpp

Issue 2781713003: Enable module scripts in ScriptLoader (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/loader/modulescript/ModuleTreeLinker.cpp
diff --git a/third_party/WebKit/Source/core/loader/modulescript/ModuleTreeLinker.cpp b/third_party/WebKit/Source/core/loader/modulescript/ModuleTreeLinker.cpp
index dc556dad598b9da1e814e7fd948d4959483630cc..000c0c0bce92420cc4774897a370cdb87482ae14 100644
--- a/third_party/WebKit/Source/core/loader/modulescript/ModuleTreeLinker.cpp
+++ b/third_party/WebKit/Source/core/loader/modulescript/ModuleTreeLinker.cpp
@@ -317,6 +317,7 @@ void ModuleTreeLinker::Instantiate() {
// Step 6. Let instantiationStatus be record.ModuleDeclarationInstantiation().
ScriptValue error = modulator_->InstantiateModule(record);
+ /*
if (!error.IsEmpty()) {
module_script_->SetInstantiationError(error.GetIsolate(), error.V8Value());
} else {
@@ -324,13 +325,14 @@ void ModuleTreeLinker::Instantiate() {
}
ModuleInstantiationState instantiation_status =
module_script_->InstantiationState();
+ */
// Step 7. For each module script script in result's uninstantiated inclusive
// descendant module scripts, perform the following steps:
HeapHashSet<Member<ModuleScript>> uninstantiated_set =
UninstantiatedInclusiveDescendants();
for (const auto& descendant : uninstantiated_set) {
- if (instantiation_status == ModuleInstantiationState::kErrored) {
+ if (!error.IsEmpty()) {
// Step 7.1. If instantiationStatus is an abrupt completion, then set
// script's
// instantiation state to "errored", its instantiation error to

Powered by Google App Engine
This is Rietveld 408576698