chrome/browser/ui/views/frame/browser_view.h - Issue 2781633003: Allow keyboard shortcuts can be captured by webpage when toolbar is not visible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/browser_view.h

Issue 2781633003: Allow keyboard shortcuts can be captured by webpage when toolbar is not visible (Closed)

Patch Set: Resolve review comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/frame/browser_view.h

diff --git a/chrome/browser/ui/views/frame/browser_view.h b/chrome/browser/ui/views/frame/browser_view.h

index d2172e5a99568b3a15133d6c131f8eb2134b1f07..d17c9e16f39fe2fa475972ff6dd4f3b89a897118 100644

--- a/chrome/browser/ui/views/frame/browser_view.h

+++ b/chrome/browser/ui/views/frame/browser_view.h

@@ -312,6 +312,7 @@ class BrowserView : public BrowserWindow,

bool IsBookmarkBarAnimating() const override;

bool IsTabStripEditable() const override;

bool IsToolbarVisible() const override;

+ bool IsToolbarShowing() const override;

void ShowUpdateChromeDialog() override;

void ShowBookmarkBubble(const GURL& url, bool already_bookmarked) override;

void ShowBookmarkAppBubble(