Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7950)

Unified Diff: chrome/browser/ui/cocoa/browser_window_cocoa.mm

Issue 2781633003: Allow keyboard shortcuts can be captured by webpage when toolbar is not visible (Closed)
Patch Set: Resolve review comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/browser_window_cocoa.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_cocoa.mm b/chrome/browser/ui/cocoa/browser_window_cocoa.mm
index 2991e80ab6535094deb95aa54984a6c72c13f3b9..d10a2e40c7d565f05ad1c8f51f632f77c499e19f 100644
--- a/chrome/browser/ui/cocoa/browser_window_cocoa.mm
+++ b/chrome/browser/ui/cocoa/browser_window_cocoa.mm
@@ -322,6 +322,16 @@ NSString* BrowserWindowCocoa::WindowTitle() {
browser_->GetWindowTitleForCurrentTab(include_app_name));
}
+bool BrowserWindowCocoa::IsToolbarShowing() const {
+ if (!IsFullscreen()) {
msw 2017/04/04 22:46:39 nit: curlies not needed
Hzj_jie 2017/04/05 18:09:17 Done.
+ return true;
msw 2017/04/04 22:46:39 optional nit: remove this conditional and just alw
Hzj_jie 2017/04/05 18:09:17 I'd prefer to keep this just in case I forgot it l
+ }
+
+ // TODO(zijiehe): Retrieve the visibility of toolbar from
msw 2017/04/04 22:46:39 nit: cite a crbug.com/#
Hzj_jie 2017/04/05 18:09:17 Done.
+ // FullscreenToolbarController.
+ return true;
+}
+
void BrowserWindowCocoa::BookmarkBarStateChanged(
BookmarkBar::AnimateChangeType change_type) {
[[controller_ bookmarkBarController]

Powered by Google App Engine
This is Rietveld 408576698