chrome/browser/ui/views/frame/browser_view.cc - Issue 2781633003: Allow keyboard shortcuts can be captured by webpage when toolbar is not visible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 2781633003: Allow keyboard shortcuts can be captured by webpage when toolbar is not visible (Closed)

Patch Set: Resolve review comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/frame/browser_view.cc

diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc

index f469f8626dd2bb50b3530f0a40a467b7f9febb50..6903b5c85ac1b54d9135212fd5fcd95aa6358b29 100644

--- a/chrome/browser/ui/views/frame/browser_view.cc

+++ b/chrome/browser/ui/views/frame/browser_view.cc

@@ -1190,6 +1190,10 @@ bool BrowserView::IsToolbarVisible() const {

toolbar_;

}

+bool BrowserView::IsToolbarShowing() const {

+ return IsToolbarVisible();

void BrowserView::ShowUpdateChromeDialog() {

UpdateRecommendedMessageBox::Show(GetNativeWindow());

}