Allow keyboard shortcuts can be captured by webpage when toolbar is not visible

chrome/browser/ui/browser_window.h

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_BROWSER_WINDOW_H_
 #define CHROME_BROWSER_UI_BROWSER_WINDOW_H_
 
 #include "base/callback_forward.h"
 #include "build/build_config.h"
 #include "chrome/browser/lifetime/browser_close_manager.h"
@@ skipping 202 matching lines @@
 
   // Returns whether the bookmark bar is visible or not.
   virtual bool IsBookmarkBarVisible() const = 0;
 
   // Returns whether the bookmark bar is animating or not.
   virtual bool IsBookmarkBarAnimating() const = 0;
 
   // Returns whether the tab strip is editable (for extensions).
   virtual bool IsTabStripEditable() const = 0;
 
-  // Returns whether the tool bar is visible or not.
+  // Returns whether the toolbar is accessible or not. It's called "Visible()"

[msw, 2017/04/04 22:46:39]

Rename this function something more representative of the toolbar's state or
return an enum like ToolbarVisibility { VISIBLE, HIDDEN, AUTOHIDE_HIDDEN,
AUTOHIDE_REVEALED } (perhaps something like this exists or there are better
existing names for this behavior/state). If you just rename this function,
'Accessible' is not a great name, evokes thoughts about a11y, maybe
IsToolbarAvailable or IsToolbarPresent (or something better...). At the very
least, add a TODO to rename and revise the comment to something like "Returns
whether the toolbar is potentially visible. This function may return true even
if the toolbar is temporarily hidden, but generally available to the user (ie.
revealed when the cursor hovers the top of the screen)." You can optionally look
at the similar ash shelf auto-hide behavior/state code (but that's admittedly
not an optimal design).

[Hzj_jie, 2017/04/05 18:09:17]

I used to rename it to IsToolbarAvailable(), which is a very reasonable name
IMO. But I found some other functions, such as IsTabStripVisible(), which are
also called "Visible", even they are returning "Available". So I doubt whether
this is a naming convention.
Returning an enum increases the complexity to the users, which, I believe, will
become a huge change. I am happy to add a TODO here to state the plan of
renaming these functions. But I definitely do not want to do it in this change
:)

+  // to follow the name convention. But it does not indicate the visibility of
+  // the toolbar, i.e. toolbar may be hidden, and only visible when the mouse
+  // cursor is at a certain place.
   virtual bool IsToolbarVisible() const = 0;
 
+  // Returns whether the toolbar is showing up on the screen.
+  virtual bool IsToolbarShowing() const = 0;
+
   // Shows the Update Recommended dialog box.
   virtual void ShowUpdateChromeDialog() = 0;
 
   // Shows the Bookmark bubble. |url| is the URL being bookmarked,
   // |already_bookmarked| is true if the url is already bookmarked.
   virtual void ShowBookmarkBubble(const GURL& url, bool already_bookmarked) = 0;
 
   // Callback type used with the ShowBookmarkAppBubble() method. The boolean
   // parameter is true when the user accepts the dialog. The WebApplicationInfo
   // parameter contains the WebApplicationInfo as edited by the user.
@@ skipping 143 matching lines @@
   virtual std::string GetWorkspace() const = 0;
   virtual bool IsVisibleOnAllWorkspaces() const = 0;
 
  protected:
   friend class BrowserCloseManager;
   friend class BrowserView;
   virtual void DestroyBrowser() = 0;
 };
 
 #endif  // CHROME_BROWSER_UI_BROWSER_WINDOW_H_