Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4976)

Unified Diff: chrome/browser/ui/webui/settings/settings_startup_pages_handler.cc

Issue 2781623006: MD Settings: Fix Appearance home page URL crash (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/settings/settings_startup_pages_handler.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/settings/settings_startup_pages_handler.cc
diff --git a/chrome/browser/ui/webui/settings/settings_startup_pages_handler.cc b/chrome/browser/ui/webui/settings/settings_startup_pages_handler.cc
index c0b870290085400195a98d217f7b29f6cfaa0bae..02e14062d8206ac75c093d31f53ce110101ad625 100644
--- a/chrome/browser/ui/webui/settings/settings_startup_pages_handler.cc
+++ b/chrome/browser/ui/webui/settings/settings_startup_pages_handler.cc
@@ -44,9 +44,6 @@ void StartupPagesHandler::RegisterMessages() {
web_ui()->RegisterMessageCallback("setStartupPagesToCurrentPages",
base::Bind(&StartupPagesHandler::HandleSetStartupPagesToCurrentPages,
base::Unretained(this)));
- web_ui()->RegisterMessageCallback("validateStartupPage",
- base::Bind(&StartupPagesHandler::HandleValidateStartupPage,
- base::Unretained(this)));
}
void StartupPagesHandler::OnJavascriptAllowed() {
@@ -182,20 +179,6 @@ void StartupPagesHandler::HandleSetStartupPagesToCurrentPages(
SaveStartupPagesPref();
}
-void StartupPagesHandler::HandleValidateStartupPage(
- const base::ListValue* args) {
- CHECK_EQ(args->GetSize(), 2U);
-
- const base::Value* callback_id;
- CHECK(args->Get(0, &callback_id));
-
- std::string url_string;
- CHECK(args->GetString(1, &url_string));
-
- bool valid = settings_utils::FixupAndValidateStartupPage(url_string, nullptr);
- ResolveJavascriptCallback(*callback_id, base::Value(valid));
-}
-
void StartupPagesHandler::SaveStartupPagesPref() {
PrefService* prefs = Profile::FromWebUI(web_ui())->GetPrefs();
« no previous file with comments | « chrome/browser/ui/webui/settings/settings_startup_pages_handler.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698