Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1386)

Unified Diff: content/browser/renderer_host/legacy_render_widget_host_win.cc

Issue 2781613003: Added a class acting as a fake caret for accessibility. (Closed)
Patch Set: Fixed rebase conflict. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/legacy_render_widget_host_win.cc
diff --git a/content/browser/renderer_host/legacy_render_widget_host_win.cc b/content/browser/renderer_host/legacy_render_widget_host_win.cc
index 7d9c181aa5479be1caa85c6a9b206e7a213a8a3d..afb6c21d7190eaff3290f8f9749d176e2760d4ea 100644
--- a/content/browser/renderer_host/legacy_render_widget_host_win.cc
+++ b/content/browser/renderer_host/legacy_render_widget_host_win.cc
@@ -5,6 +5,7 @@
#include "content/browser/renderer_host/legacy_render_widget_host_win.h"
#include <memory>
+#include <utility>
#include "base/command_line.h"
#include "base/win/win_util.h"
@@ -15,6 +16,7 @@
#include "content/browser/renderer_host/render_widget_host_impl.h"
#include "content/browser/renderer_host/render_widget_host_view_aura.h"
#include "content/public/common/content_switches.h"
+#include "ui/accessibility/platform/ax_fake_caret_win.h"
#include "ui/base/view_prop.h"
#include "ui/base/win/internal_constants.h"
#include "ui/base/win/window_event_target.h"
@@ -85,6 +87,11 @@ void LegacyRenderWidgetHostHWND::SetBounds(const gfx::Rect& bounds) {
direct_manipulation_helper_->SetBounds(bounds_in_pixel);
}
+void LegacyRenderWidgetHostHWND::MoveCaretTo(const gfx::Rect& bounds) {
+ DCHECK(ax_fake_caret_);
+ ax_fake_caret_->MoveCaretTo(bounds);
+}
+
void LegacyRenderWidgetHostHWND::OnFinalMessage(HWND hwnd) {
if (host_) {
host_->OnLegacyWindowDestroyed();
@@ -98,12 +105,15 @@ void LegacyRenderWidgetHostHWND::OnFinalMessage(HWND hwnd) {
}
LegacyRenderWidgetHostHWND::LegacyRenderWidgetHostHWND(HWND parent)
- : mouse_tracking_enabled_(false),
- host_(NULL) {
+ : mouse_tracking_enabled_(false), host_(nullptr) {
RECT rect = {0};
Base::Create(parent, rect, L"Chrome Legacy Window",
WS_CHILDWINDOW | WS_CLIPCHILDREN | WS_CLIPSIBLINGS,
WS_EX_TRANSPARENT);
+ // We create the fake caret regardless of accessibility mode since not all
+ // assistive software that makes use of a fake caret is classified as a screen
+ // reader, e.g. the built-in Windows Magnifier.
+ ax_fake_caret_ = std::make_unique<ui::AXFakeCaretWin>(hwnd());
}
LegacyRenderWidgetHostHWND::~LegacyRenderWidgetHostHWND() {
@@ -170,24 +180,36 @@ LRESULT LegacyRenderWidgetHostHWND::OnGetObject(UINT message,
return static_cast<LRESULT>(0L);
}
- if (static_cast<DWORD>(OBJID_CLIENT) != obj_id || !host_)
+ if (!host_)
return static_cast<LRESULT>(0L);
- RenderWidgetHostImpl* rwhi = RenderWidgetHostImpl::From(
- host_->GetRenderWidgetHost());
- if (!rwhi)
- return static_cast<LRESULT>(0L);
+ if (static_cast<DWORD>(OBJID_CLIENT) == obj_id) {
+ RenderWidgetHostImpl* rwhi =
+ RenderWidgetHostImpl::From(host_->GetRenderWidgetHost());
+ if (!rwhi)
+ return static_cast<LRESULT>(0L);
+
+ BrowserAccessibilityManagerWin* manager =
+ static_cast<BrowserAccessibilityManagerWin*>(
+ rwhi->GetRootBrowserAccessibilityManager());
+ if (!manager)
+ return static_cast<LRESULT>(0L);
+
+ base::win::ScopedComPtr<IAccessible> root(
+ ToBrowserAccessibilityWin(manager->GetRoot())->GetCOM());
+ return LresultFromObject(IID_IAccessible, w_param,
+ static_cast<IAccessible*>(root.Detach()));
+ }
- BrowserAccessibilityManagerWin* manager =
- static_cast<BrowserAccessibilityManagerWin*>(
- rwhi->GetRootBrowserAccessibilityManager());
- if (!manager)
- return static_cast<LRESULT>(0L);
+ if (static_cast<DWORD>(OBJID_CARET) == obj_id && host_->HasFocus()) {
+ DCHECK(ax_fake_caret_);
+ base::win::ScopedComPtr<IAccessible> fake_caret_accessible =
+ ax_fake_caret_->GetCaret();
+ return LresultFromObject(IID_IAccessible, w_param,
+ fake_caret_accessible.Detach());
+ }
- base::win::ScopedComPtr<IAccessible> root(
- ToBrowserAccessibilityWin(manager->GetRoot())->GetCOM());
- return LresultFromObject(IID_IAccessible, w_param,
- static_cast<IAccessible*>(root.Detach()));
+ return static_cast<LRESULT>(0L);
}
// We send keyboard/mouse/touch messages to the parent window via SendMessage.

Powered by Google App Engine
This is Rietveld 408576698