[Content suggestions] Add a function to the service API to fetch favicons

components/ntp_snippets/content_suggestions_service.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_NTP_SNIPPETS_CONTENT_SUGGESTIONS_SERVICE_H_
 #define COMPONENTS_NTP_SNIPPETS_CONTENT_SUGGESTIONS_SERVICE_H_
 
 #include <map>
 #include <memory>
 #include <set>
@@ skipping 106 matching lines @@
   const std::vector<ContentSuggestion>& GetSuggestionsForCategory(
       Category category) const;
 
   // Fetches the image for the suggestion with the given |suggestion_id| and
   // runs the |callback|. If that suggestion doesn't exist or the fetch fails,
   // the callback gets an empty image. The callback will not be called
   // synchronously.
   void FetchSuggestionImage(const ContentSuggestion::ID& suggestion_id,
                             const ImageFetchedCallback& callback);
 
+  // Fetches the favicon from local cache (if larger than

[Michael van Ouwerkerk, 2017/03/28 11:23:56]

"large than", or "larger than or equal to"?

[jkrcal, 2017/03/28 13:12:53]

Done.

+  // |minimum_size_in_pixel|) or from Google server (if there is no icon in the
+  // cache) and returns the resuls in the callback. If that suggestion doesn't

[Michael van Ouwerkerk, 2017/03/28 11:23:56]

s/resuls/results/

[jkrcal, 2017/03/28 13:12:53]

Done.

+  // exist or the fetch fails, the callback gets an empty image. The callback

[Michael van Ouwerkerk, 2017/03/28 11:23:56]

In the Java docs, it says we may get a null Bitmap, but here it says we may get
an empty image. I think I'd prefer the null case, it's more explicit.

[jkrcal, 2017/03/28 13:12:53]

The difference between c++ and java makes sense. "Being empty" is a standard
notion for a passed-by-reference gfx::Image:
https://cs.chromium.org/chromium/src/ui/gfx/image/image.h?sq=package:chromium...

+  // will not be called synchronously.
+  void FetchSuggestionFavicon(const ContentSuggestion::ID& suggestion_id,
+                              int minimum_size_in_pixel,
+                              int desired_size_in_pixel,
+                              const ImageFetchedCallback& callback);
+
   // Dismisses the suggestion with the given |suggestion_id|, if it exists.
   // This will not trigger an update through the observers (i.e. providers must
   // not call |Observer::OnNewSuggestions|).
   void DismissSuggestion(const ContentSuggestion::ID& suggestion_id);
 
   // Dismisses the given |category|, if it exists.
   // This will not trigger an update through the observers.
   void DismissCategory(Category category);
 
   // Restores all dismissed categories.
@@ skipping 213 matching lines @@
 
   // Provides order for categories.
   std::unique_ptr<CategoryRanker> category_ranker_;
 
   DISALLOW_COPY_AND_ASSIGN(ContentSuggestionsService);
 };
 
 }  // namespace ntp_snippets
 
 #endif  // COMPONENTS_NTP_SNIPPETS_CONTENT_SUGGESTIONS_SERVICE_H_