Integrate Desktop iOS promotion with bookmarks.

chrome/browser/ui/views/bookmarks/bookmark_bubble_browsertest.cc

+// Copyright (c) 2017 The Chromium Authors. All rights reserved.

[sky, 2017/03/29 21:54:34]

Name this file bookmark_bubble_view_browsertest to match the class under test.

[sky, 2017/03/29 21:54:36]

no (c) (see style guide)

[mrefaat, 2017/03/30 17:37:14]

Done.

[mrefaat, 2017/03/30 17:37:15]

Ack, But we need to change the presubmit rule, i got presubmit warning about
that i should match 
.*? Copyright (\(c\)
)?(2017|2016|2015|2014|2013|2012|2011|2010|2009|2008|2007|2006|2006-2008|2006-2009|2006-2010)
The Chromium Authors\. All rights reserved\.\n.*? Use of this source code is
governed by a BSD-style license that can be\n.*? found in the LIC
ENSE file\.(?: \*/)?\n

[sky, 2017/03/30 20:30:17]

You must be doing something else wrong if you need the (c). See
https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md ,
which says "There is no (c) after Copyright.".

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/bookmarks/bookmark_model_factory.h"
+#include "chrome/browser/signin/fake_signin_manager_builder.h"
+#include "chrome/browser/signin/signin_manager_factory.h"
+#include "chrome/browser/ui/test/test_browser_dialog.h"
+#include "chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h"
+#include "chrome/browser/ui/views/frame/browser_view.h"
+#include "chrome/browser/ui/views/location_bar/star_view.h"
+#include "chrome/browser/ui/views/toolbar/toolbar_view.h"
+#include "chrome/test/base/browser_with_test_window_test.h"
+#include "components/bookmarks/browser/bookmark_utils.h"
+#include "components/bookmarks/test/bookmark_test_helpers.h"
+
+namespace {
+
+const char kTestBookmarkURL[] = "http://www.google.com";
+const char kTestGaiaID[] = "test";
+const char kTestUserEmail[] = "testuser@gtest.com";
+
+}  // namespace
+
+class BookmarkBubbleBrowserTest : public DialogBrowserTest {

[sky, 2017/03/29 21:54:35]

And name this to match bookmarkbubbleview too.

[mrefaat, 2017/03/30 17:37:15]

Done.

+ public:
+  BookmarkBubbleBrowserTest() {}
+
+  void SetUpOnMainThread() override {
+    TestingProfile::Builder builder;
+    builder.AddTestingFactory(SigninManagerFactory::GetInstance(),
+                              BuildFakeSigninManagerBase);
+    profile_ = builder.Build();
+    profile_->CreateBookmarkModel(true);
+    bookmarks::BookmarkModel* bookmark_model =
+        BookmarkModelFactory::GetForBrowserContext(profile());

[sky, 2017/03/29 21:54:37]

You use profile_ above, and profile() here. Please use profile_ everywhere and
remove profile() as there isn't a real need for it.

[mrefaat, 2017/03/30 17:37:15]

i thought its better than using profile_.get() everywhere - removed it.

+    bookmarks::test::WaitForBookmarkModelToLoad(bookmark_model);
+    bookmarks::AddIfNotBookmarked(bookmark_model, GURL(kTestBookmarkURL),
+                                  base::string16());
+  }
+
+  void TearDownOnMainThread() override { profile_.reset(); }
+
+  TestingProfile* profile() { return profile_.get(); }
+
+  void ShowDialog(const std::string& name) override {
+    BrowserView* browser_view =

[sky, 2017/03/29 21:54:34]

GetBrowserViewForBrowser(browser()).

[mrefaat, 2017/03/30 17:37:15]

Done.

+        reinterpret_cast<BrowserView*>(browser()->window());
+
+    if ("bookmark_details" == name) {
+      SigninManagerFactory::GetForProfile(profile())->SignOut(
+          signin_metrics::SIGNOUT_TEST,
+          signin_metrics::SignoutDelete::IGNORE_METRIC);
+      BookmarkBubbleView::ShowBubble(
+          browser_view->toolbar()->location_bar()->star_view(), gfx::Rect(),
+          nullptr, nullptr, nullptr, profile(), GURL(kTestBookmarkURL), true);
+    } else if ("bookmark_details_signed_in" == name) {
+      SigninManagerFactory::GetForProfile(profile())
+          ->SetAuthenticatedAccountInfo(kTestGaiaID, kTestUserEmail);
+      BookmarkBubbleView::ShowBubble(
+          browser_view->toolbar()->location_bar()->star_view(), gfx::Rect(),
+          nullptr, nullptr, nullptr, profile(), GURL(kTestBookmarkURL), true);
+#if defined(OS_WIN)
+    } else if ("ios_promotion" == name) {
+      SigninManagerFactory::GetForProfile(profile())
+          ->SetAuthenticatedAccountInfo(kTestGaiaID, kTestUserEmail);
+      BookmarkBubbleView::ShowBubble(
+          browser_view->toolbar()->location_bar()->star_view(), gfx::Rect(),
+          nullptr, nullptr, nullptr, profile(), GURL(kTestBookmarkURL), true);
+      BookmarkBubbleView::bookmark_bubble()->ShowIOSPromotion();
+#endif
+    }
+  }
+
+ protected:
+  std::unique_ptr<TestingProfile> profile_;

[sky, 2017/03/29 21:54:34]

Move to private_ ? Tests allow for protected members, but it doesn't seem that
you need it to be protected.

[mrefaat, 2017/03/30 17:37:15]

Done.

+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(BookmarkBubbleBrowserTest);
+};
+
+IN_PROC_BROWSER_TEST_F(BookmarkBubbleBrowserTest,
+                       InvokeDialog_bookmark_details) {
+  RunDialog();
+}
+
+IN_PROC_BROWSER_TEST_F(BookmarkBubbleBrowserTest,
+                       InvokeDialog_bookmark_details_signed_in) {
+  RunDialog();
+}
+
+#if defined(OS_WIN)
+IN_PROC_BROWSER_TEST_F(BookmarkBubbleBrowserTest, InvokeDialog_ios_promotion) {
+  RunDialog();
+}
+#endif