Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2781483007: Report error if the same uri appears in multiple summaries. (Closed)

Created:
3 years, 8 months ago by vsm
Modified:
3 years, 8 months ago
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Report error if the same uri appears in multiple summaries. Fixes #27025 R=brianwilkerson@google.com, jmesserly@google.com Committed: https://github.com/dart-lang/sdk/commit/2afa21bb2c5b2b349f49f4147fc7e898ad1a5d64

Patch Set 1 #

Patch Set 2 : Beautify the error message #

Patch Set 3 : Refactor and check in analyzer cli #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -3 lines) Patch
M pkg/analyzer/lib/src/summary/package_bundle_reader.dart View 1 2 5 chunks +63 lines, -1 line 0 comments Download
M pkg/analyzer_cli/lib/src/build_mode.dart View 1 2 1 chunk +7 lines, -1 line 0 comments Download
M pkg/dev_compiler/lib/sdk/ddc_sdk.sum View Binary file 0 comments Download
M pkg/dev_compiler/lib/src/compiler/command.dart View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M pkg/dev_compiler/lib/src/compiler/compiler.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/dev_compiler/test/worker/worker_test.dart View 3 chunks +60 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
vsm
3 years, 8 months ago (2017-03-29 18:26:28 UTC) #3
vsm
PTAL Cleaned up the error message. This is triggering internally in a handful of places ...
3 years, 8 months ago (2017-03-30 00:05:24 UTC) #4
vsm
On 2017/03/30 00:05:24, vsm wrote: > PTAL > > Cleaned up the error message. This ...
3 years, 8 months ago (2017-03-30 15:01:57 UTC) #5
Brian Wilkerson
lgtm
3 years, 8 months ago (2017-03-30 16:00:03 UTC) #6
Jennifer Messerly
lgtm!
3 years, 8 months ago (2017-03-30 20:46:54 UTC) #7
vsm
3 years, 8 months ago (2017-04-17 14:33:09 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
2afa21bb2c5b2b349f49f4147fc7e898ad1a5d64 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698