runtime/vm/precompiler.cc - Issue 2781483005: Improve internal compiler API so that OSR code is never installed on function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/precompiler.cc

Issue 2781483005: Improve internal compiler API so that OSR code is never installed on function. (Closed)

Patch Set: cosmetics Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/precompiler.cc

diff --git a/runtime/vm/precompiler.cc b/runtime/vm/precompiler.cc

index 422d60aaeea703f7a08b3520bb11b285c8f5b1ab..63f4072c35ef5aed8c479fe20b5cac7b12a686ab 100644

--- a/runtime/vm/precompiler.cc

+++ b/runtime/vm/precompiler.cc

@@ -2946,7 +2946,7 @@ void PrecompileParsedFunctionHelper::FinalizeCompilation(

if (optimized()) {

// Installs code while at safepoint.

ASSERT(thread()->IsMutatorThread());

- function.InstallOptimizedCode(code, /* is_osr = */ false);

+ function.InstallOptimizedCode(code);

} else { // not optimized.

function.set_unoptimized_code(code);

function.AttachCode(code);

« no previous file with comments | « runtime/vm/object.cc ('k') | runtime/vm/unit_test.cc » ('j') | no next file with comments »