Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2427)

Unified Diff: runtime/lib/mirrors.cc

Issue 2781483005: Improve internal compiler API so that OSR code is never installed on function. (Closed)
Patch Set: cosmetics Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/code_generator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/mirrors.cc
diff --git a/runtime/lib/mirrors.cc b/runtime/lib/mirrors.cc
index 1dade418b20d37dcac6e91577b4a9dfe5a4c9293..ca62ecf4be549015438ad3b7e11f702513ed4b0a 100644
--- a/runtime/lib/mirrors.cc
+++ b/runtime/lib/mirrors.cc
@@ -95,14 +95,7 @@ static void EnsureConstructorsAreCompiled(const Function& func) {
Exceptions::PropagateError(error);
UNREACHABLE();
}
- if (!func.HasCode()) {
- const Error& error =
- Error::Handle(zone, Compiler::CompileFunction(thread, func));
- if (!error.IsNull()) {
- Exceptions::PropagateError(error);
- UNREACHABLE();
- }
- }
+ func.EnsureHasCode();
}
static RawInstance* CreateParameterMirrorList(const Function& func,
« no previous file with comments | « no previous file | runtime/vm/code_generator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698