Improve internal compiler API so that OSR code is never installed on function.

runtime/vm/object.h

Index: runtime/vm/object.h
diff --git a/runtime/vm/object.h b/runtime/vm/object.h
index 2239799140a8983cd3d7bf3ae7e781314fe23db2..9e3f2cbdca8257358d7a774a3b62adaed0e72c37 100644
--- a/runtime/vm/object.h
+++ b/runtime/vm/object.h
@@ -2293,7 +2293,7 @@ class Function : public Object {
 
   // Not thread-safe; must be called in the main thread.
   // Sets function's code and code's function.
-  void InstallOptimizedCode(const Code& code, bool is_osr) const;
+  void InstallOptimizedCode(const Code& code) const;
   void AttachCode(const Code& value) const;
   void SetInstructions(const Code& value) const;
   void ClearCode() const;
@@ -2301,6 +2301,8 @@ class Function : public Object {
   // Disables optimized code and switches to unoptimized code.
   void SwitchToUnoptimizedCode() const;
 
+  RawCode* EnsureHasCode() const;

[Vyacheslav Egorov (Google), 2017/03/30 13:25:01]

Write a comment about what this function does.

[erikcorry, 2017/03/30 13:33:33]

Done.

+
   // Disables optimized code and switches to unoptimized code (or the lazy
   // compilation stub).
   void SwitchToLazyCompiledUnoptimizedCode() const;