Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 2781483002: Mostly use Entity in InterceptorData (Closed)

Created:
3 years, 9 months ago by Johnni Winther
Modified:
3 years, 9 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Mostly use Entity in InterceptorData This is a step towards making InterceptorDataImpl reusable for J/K-elements. R=efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/40072e2cce88bff291b9051cde98b78cb44254d8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -78 lines) Patch
M pkg/compiler/lib/src/common/codegen.dart View 6 chunks +9 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/common_elements.dart View 1 chunk +12 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 1 chunk +20 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 chunk +5 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/impact_transformer.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/interceptor_data.dart View 12 chunks +57 lines, -63 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/minify_namer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/kernel/world_builder.dart View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 9 months ago (2017-03-27 12:21:10 UTC) #2
Emily Fortuna
lgtm
3 years, 9 months ago (2017-03-27 18:17:25 UTC) #3
Johnni Winther
3 years, 9 months ago (2017-03-28 08:53:14 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
40072e2cce88bff291b9051cde98b78cb44254d8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698