Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2106)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2781473004: Remove some additional code that depended on the old type propagation. (Closed)

Created:
3 years, 8 months ago by asgerf
Modified:
3 years, 8 months ago
CC:
dart-kernel+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove some additional code that depended on the old type propagation. BUG= R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/f396d919ae94d1ac0473caa10d90a41235d8d23a

Patch Set 1 #

Patch Set 2 : Update fasta shadow AST #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1316 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart View 1 2 chunks +4 lines, -10 lines 0 comments Download
M pkg/kernel/lib/transformations/closure/converter.dart View 1 chunk +0 lines, -1 line 0 comments Download
D pkg/kernel/testcases/type-propagation/DeltaBlue.baseline.txt View 1 chunk +0 lines, -450 lines 0 comments Download
D pkg/kernel/testcases/type-propagation/argument.baseline.txt View 1 chunk +0 lines, -37 lines 0 comments Download
D pkg/kernel/testcases/type-propagation/arithmetic.baseline.txt View 1 chunk +0 lines, -18 lines 0 comments Download
D pkg/kernel/testcases/type-propagation/async_function.baseline.txt View 1 chunk +0 lines, -31 lines 0 comments Download
D pkg/kernel/testcases/type-propagation/bad_store.baseline.txt View 1 chunk +0 lines, -24 lines 0 comments Download
D pkg/kernel/testcases/type-propagation/call.baseline.txt View 1 chunk +0 lines, -48 lines 0 comments Download
D pkg/kernel/testcases/type-propagation/closure.baseline.txt View 1 chunk +0 lines, -27 lines 0 comments Download
D pkg/kernel/testcases/type-propagation/covariant_generic.baseline.txt View 1 chunk +0 lines, -38 lines 0 comments Download
D pkg/kernel/testcases/type-propagation/escape.baseline.txt View 1 chunk +0 lines, -50 lines 0 comments Download
D pkg/kernel/testcases/type-propagation/external.baseline.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D pkg/kernel/testcases/type-propagation/fallthrough.baseline.txt View 1 chunk +0 lines, -38 lines 0 comments Download
D pkg/kernel/testcases/type-propagation/micro.baseline.txt View 1 chunk +0 lines, -81 lines 0 comments Download
D pkg/kernel/testcases/type-propagation/named_parameters.baseline.txt View 1 chunk +0 lines, -31 lines 0 comments Download
D pkg/kernel/testcases/type-propagation/null_aware.baseline.txt View 1 chunk +0 lines, -22 lines 0 comments Download
D pkg/kernel/testcases/type-propagation/optional.baseline.txt View 1 chunk +0 lines, -61 lines 0 comments Download
D pkg/kernel/testcases/type-propagation/override.baseline.txt View 1 chunk +0 lines, -35 lines 0 comments Download
D pkg/kernel/testcases/type-propagation/prefer_baseclass.baseline.txt View 1 chunk +0 lines, -42 lines 0 comments Download
D pkg/kernel/testcases/type-propagation/redirecting_factory.baseline.txt View 1 chunk +0 lines, -53 lines 0 comments Download
D pkg/kernel/testcases/type-propagation/static_setter.baseline.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D pkg/kernel/testcases/type-propagation/store_load.baseline.txt View 1 chunk +0 lines, -36 lines 0 comments Download
D pkg/kernel/testcases/type-propagation/stringliteral.baseline.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D pkg/kernel/testcases/type-propagation/uninitialized_fields.baseline.txt View 1 chunk +0 lines, -37 lines 0 comments Download
D pkg/kernel/testcases/type-propagation/unused_methods.baseline.txt View 1 chunk +0 lines, -86 lines 0 comments Download
D pkg/kernel/testcases/type-propagation/void-methods.baseline.txt View 1 chunk +0 lines, -21 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
asgerf
3 years, 8 months ago (2017-03-28 11:38:18 UTC) #2
Kevin Millikin (Google)
LGTM.
3 years, 8 months ago (2017-03-28 11:50:12 UTC) #3
asgerf
3 years, 8 months ago (2017-03-28 11:51:31 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
f396d919ae94d1ac0473caa10d90a41235d8d23a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698