Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: pkg/analyzer/test/src/context/context_test.dart

Issue 2781443003: Fix #28120, strong mode allows field overrides (Closed)
Patch Set: add doc comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/test/generated/compile_time_error_code_test.dart ('k') | pkg/analyzer/test/src/task/strong/checker_test.dart » ('j') | pkg/dev_compiler/lib/src/compiler/element_helpers.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/src/context/context_test.dart
diff --git a/pkg/analyzer/test/src/context/context_test.dart b/pkg/analyzer/test/src/context/context_test.dart
index 8374e0501d195530e5c914e1b63110a6d2991da1..441cad9c485222d6c705c63c4f422c986a8c73e9 100644
--- a/pkg/analyzer/test/src/context/context_test.dart
+++ b/pkg/analyzer/test/src/context/context_test.dart
@@ -4326,9 +4326,8 @@ class B extends A {
}
''');
_performPendingAnalysisTasks();
- expect(context.getErrors(a).errors, hasLength(2));
+ expect(context.getErrors(a).errors, hasLength(1));
// Update a.dart: rename "int foo" to "int bar".
- // The strong mode "getter cannot override field" error is gone.
context.setContents(
a,
r'''
« no previous file with comments | « pkg/analyzer/test/generated/compile_time_error_code_test.dart ('k') | pkg/analyzer/test/src/task/strong/checker_test.dart » ('j') | pkg/dev_compiler/lib/src/compiler/element_helpers.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698