[Bindings] Specialize WindowDocument symbol in V8PrivateProperty

third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "bindings/core/v8/V8PrivateProperty.h"
 
 #include "bindings/core/v8/ScriptState.h"
 #include "bindings/core/v8/ScriptWrappable.h"
 #include "bindings/core/v8/V8Binding.h"
 #include "bindings/core/v8/V8BindingMacros.h"
 
 namespace blink {
 
+static inline v8::Local<v8::String> createV8String(v8::Isolate* isolate,

[Yuki, 2017/03/28 08:17:59]

nit: anonymous namespace is preferred.
nit: inline may not have much effect because compilers may optimize the code
without 'inline' keyword.

[jbroman, 2017/03/30 15:55:55]

nit: This function is equivalent to v8String; consider using that instead?

[peria, 2017/03/31 04:26:50]

Done.

+                                                   const char* symbol,
+                                                   size_t length) {
+  return v8::String::NewFromOneByte(
+             isolate, reinterpret_cast<const uint8_t*>(symbol),
+             v8::NewStringType::kNormal, static_cast<int>(length))
+      .ToLocalChecked();
+}
+
 v8::Local<v8::Value> V8PrivateProperty::Symbol::getFromMainWorld(
     ScriptState* scriptState,
     ScriptWrappable* scriptWrappable) {
   v8::Local<v8::Object> wrapper =
       scriptWrappable->mainWorldWrapper(scriptState->isolate());
   return wrapper.IsEmpty() ? v8::Local<v8::Value>()
                            : get(scriptState->context(), wrapper);
 }
 
 v8::Local<v8::Private> V8PrivateProperty::createV8Private(v8::Isolate* isolate,
                                                           const char* symbol,
                                                           size_t length) {
-  v8::Local<v8::String> str =
-      v8::String::NewFromOneByte(
-          isolate, reinterpret_cast<const uint8_t*>(symbol),
-          v8::NewStringType::kNormal, static_cast<int>(length))
-          .ToLocalChecked();
-  return v8::Private::New(isolate, str);
+  return v8::Private::New(isolate, createV8String(isolate, symbol, length));
+}
+
+v8::Local<v8::Private> V8PrivateProperty::createCachedV8Private(

[Yuki, 2017/03/28 08:17:59]

nit: You may want a TODO comment here, too, to remove this function.

[peria, 2017/03/31 04:26:50]

I'm not confident, but this method can be usable for properties
in generated code.

+    v8::Isolate* isolate,
+    const char* symbol,
+    size_t length) {
+  return v8::Private::ForApi(isolate, createV8String(isolate, symbol, length));
 }
 
 }  // namespace blink