Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 278143003: Revert of Update DomDistillerJsUpdater and Roll DomDistillerJs (Closed)

Created:
6 years, 7 months ago by Alpha Left Google
Modified:
6 years, 7 months ago
Reviewers:
cjhopman, Yaron
CC:
chromium-reviews
Visibility:
Public.

Description

Revert of Update DomDistillerJsUpdater and Roll DomDistillerJs (https://codereview.chromium.org/277563002/) Reason for revert: check_licenses failure: http://build.chromium.org/p/chromium/builders/Linux/builds/49667 Original issue's description: > Update DomDistillerJsUpdater and Roll DomDistillerJs > > The update script should build `ant package` and copy the entire > out/package directory. > > This moves the path to domdistiller.js to .../package/js so update > that reference. > > The old (non-proto) API is still supported, so this keeps using that. > > Picked up changes: > fdb023d Fix Proto module's path > 44e9366 This adds two simple protoc plugins. > > NOTRY=true > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269485 TBR=yfriedman@chromium.org,cjhopman@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269553

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+499 lines, -715 lines) Patch
M components/dom_distiller/core/javascript/domdistiller.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/dom_distiller_js/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
A third_party/dom_distiller_js/js/domdistiller.js View 1 chunk +493 lines, -0 lines 0 comments Download
D third_party/dom_distiller_js/package/js/domdistiller.js View 1 chunk +0 lines, -496 lines 0 comments Download
D third_party/dom_distiller_js/package/proto/dom_distiller.proto View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/dom_distiller_js/package/proto_gen/dom_distiller_js/dom_distiller_json_converter.h View 1 chunk +0 lines, -182 lines 0 comments Download
M third_party/dom_distiller_js/update_domdistiller_js.sh View 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Alpha Left Google
Created Revert of Update DomDistillerJsUpdater and Roll DomDistillerJs
6 years, 7 months ago (2014-05-10 06:20:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/278143003/1
6 years, 7 months ago (2014-05-10 06:21:50 UTC) #2
commit-bot: I haz the power
6 years, 7 months ago (2014-05-10 06:51:09 UTC) #3
Message was sent while issue was closed.
Change committed as 269553

Powered by Google App Engine
This is Rietveld 408576698