Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 2781423003: Start preparing tests to accept binary compiler input. (Closed)

Created:
3 years, 8 months ago by Emily Fortuna
Modified:
3 years, 8 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Start preparing tests to accept binary compiler input. BUG= R=johnniwinther@google.com Committed: https://github.com/dart-lang/sdk/commit/4588dceaf3ce3e76ad2225f7f94dabbc4e28584e

Patch Set 1 : .. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -27 lines) Patch
M pkg/compiler/lib/src/source_file_provider.dart View 3 chunks +1 line, -6 lines 0 comments Download
M pkg/compiler/lib/src/use_unused_api.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/compiler/dart2js/bad_loop_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/library_resolution_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/memory_compiler.dart View 4 chunks +7 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/memory_source_file_helper.dart View 2 chunks +22 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
Emily Fortuna
3 years, 8 months ago (2017-03-31 00:57:11 UTC) #3
Johnni Winther
lgtm
3 years, 8 months ago (2017-03-31 06:33:52 UTC) #5
Emily Fortuna
3 years, 8 months ago (2017-03-31 17:18:23 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:40001) manually as
4588dceaf3ce3e76ad2225f7f94dabbc4e28584e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698