Issue 278133002: Don't save history state for frames that were initially blocked due to mixed content.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 278133002: Don't save history state for frames that were initially blocked due to mixed content. (Closed)

Created:
6 years, 7 months ago by Nate Chapin

Modified:
6 years, 7 months ago

Reviewers:
abarth-chromium

CC:
blink-reviews, Nate Chapin, gavinp+loader_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Don't save history state for frames that were initially blocked due to mixed content. BUG=348952 TEST=Added a dumpBackForwardList() to http/tests/security/mixedContent/insecure-iframe-in-main-frame.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173812

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -4 lines)			Patch
M	LayoutTests/http/tests/security/mixedContent/insecure-iframe-in-main-frame.html	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	LayoutTests/http/tests/security/mixedContent/insecure-iframe-in-main-frame-expected.txt	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	Source/core/loader/FrameLoader.cpp	View	2 chunks	+7 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/278133002/1

6 years, 7 months ago (2014-05-10 01:55:13 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...

6 years, 7 months ago (2014-05-10 02:35:43 UTC) #5

Message was sent while issue was closed.

Change committed as 173812

Expand Messages | Collapse Messages