chrome/android/java/res/layout/data_usage_breakdown.xml - Issue 2781323004: Create a new Data Saver settings page that adds the site breakdown

Side by Side Diff: chrome/android/java/res/layout/data_usage_breakdown.xml

Issue 2781323004: Create a new Data Saver settings page that adds the site breakdown (Closed)

Patch Set: one preference to inflate two different layouts Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« build/android/lint/suppressions.xml ('K') | « chrome/android/java/res/layout/data_reduction_stats_layout.xml ('k') | chrome/android/java/res/layout/data_usage_breakdown_row.xml » ('j') | chrome/android/java/res/layout/data_usage_breakdown_row.xml » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2017 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5

	6 <org.chromium.chrome.browser.preferences.datareduction.DataReductionSiteBreakdow nView

	7 xmlns:android="http://schemas.android.com/apk/res/android"

	8 xmlns:settings="http://schemas.android.com/apk/res-auto"

	9 android:id="@+id/breakdown"

	10 android:layout_height="wrap_content"

	11 android:layout_width="match_parent"

	12 android:orientation="vertical"

	13 android:visibility="gone">

	14

	15 <TextView

	16 android:id="@+id/data_reduction_data_usage_breakdown_title"

	17 android:layout_width="match_parent"

	18 android:layout_height="wrap_content"

	19 android:layout_marginTop="26dp"

	20 android:paddingBottom="10dp"

	21 android:singleLine="true"

	22 android:text="@string/data_reduction_data_usage_breakdown_title"

	23 android:textAppearance="@style/PreferenceCategoryTextStyle" />

	24

	25 <TableLayout

	26 android:id="@+id/data_reduction_proxy_breakdown_table"

	27 android:layout_width="match_parent"

	28 android:layout_height="wrap_content"

	29 android:divider="?android:attr/dividerHorizontal"

	30 android:showDividers="middle"

	31 android:stretchColumns="0">

	32

	33 <TableRow

	34 android:id="@+id/data_reduction_proxy_breakdown_table_labels"

	35 android:layout_height="wrap_content"

	36 android:layout_width="match_parent"

	37 android:orientation="horizontal">

	38

	39 <TextView

	40 android:text="@string/data_reduction_breakdown_site_title"

	41 android:layout_height="wrap_content"

	42 android:layout_width="0dp"

	43 android:layout_weight="1"

	44 android:paddingBottom="10dp"

	45 android:paddingTop="10dp"

	46 android:paddingEnd="10dp"

	47 android:singleLine="true"
	Theresa 2017/04/03 15:05:20 nit: a lot of this styling can be pulled out into nit: a lot of this styling can be pulled out into a rule in styles.xml. It looks like the paddingBottom, paddintGop, paddingStart, singleLine, textSize, and textAppearance are all the same between these three text views. megjablon 2017/04/03 20:33:44 Done. Show quoted text On 2017/04/03 15:05:20, Theresa wrote: > nit: a lot of this styling can be pulled out into a rule in styles.xml. It looks > like the paddingBottom, paddintGop, paddingStart, singleLine, textSize, and > textAppearance are all the same between these three text views. Done.
	48 android:textColor="?android:attr/textColorSecondary"

	49 android:textSize="16sp"

	50 android:textAppearance="@style/RobotoMediumStyle" />

	51

	52 <TextView

	53 android:text="@string/data_reduction_breakdown_used_title"

	54 android:layout_height="wrap_content"

	55 android:layout_width="wrap_content"

	56 android:gravity="end"

	57 android:paddingBottom="10dp"

	58 android:paddingTop="10dp"

	59 android:paddingStart="10dp"

	60 android:singleLine="true"

	61 android:textColor="?android:attr/textColorPrimary"

	62 android:textSize="16sp"

	63 android:textAppearance="@style/RobotoMediumStyle" />

	64

	65 <TextView

	66 android:text="@string/data_reduction_breakdown_saved_title"

	67 android:layout_height="wrap_content"

	68 android:layout_width="wrap_content"

	69 android:gravity="end"

	70 android:paddingBottom="10dp"

	71 android:paddingTop="10dp"

	72 android:paddingStart="24dp"

	73 android:singleLine="true"

	74 android:textColor="?android:attr/textColorSecondary"

	75 android:textSize="16sp"

	76 android:textAppearance="@style/RobotoMediumStyle" />

	77

	78 </TableRow>

	79

	80 </TableLayout>

	81

	82 <Button

	83 android:id="@+id/data_reduction_reset_statistics"

	84 android:layout_width="match_parent"

	85 android:layout_height="wrap_content"

	86 android:layout_gravity="center"

	87 android:layout_marginTop="24dp"

	88 android:text="@string/data_reduction_usage_reset_statistics_button"

	89 android:textAllCaps="true"

	90 android:textColor="@color/light_active_color"

	91 android:textSize="16sp"

	92 style="@style/ButtonCompatBorderless" />

	93

	94 </org.chromium.chrome.browser.preferences.datareduction.DataReductionSiteBreakdo wnView>

OLD	NEW