Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 <?xml version="1.0" encoding="utf-8"?> | 1 <?xml version="1.0" encoding="utf-8"?> |
| 2 <lint> | 2 <lint> |
| 3 <!-- | 3 <!-- |
| 4 STOP! It looks like you want to suppress some lint errors: | 4 STOP! It looks like you want to suppress some lint errors: |
| 5 - Have you tried identifing the offending patch? | 5 - Have you tried identifing the offending patch? |
| 6 Ask the author for a fix and/or revert the patch. | 6 Ask the author for a fix and/or revert the patch. |
| 7 - It is preferred to add suppressions in the code instead of | 7 - It is preferred to add suppressions in the code instead of |
| 8 sweeping it under the rug here. See: | 8 sweeping it under the rug here. See: |
| 9 | 9 |
| 10 http://developer.android.com/tools/debugging/improving-w-lint.html | 10 http://developer.android.com/tools/debugging/improving-w-lint.html |
| (...skipping 415 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 426 <ignore regexp="content/shell/android/linker_test_apk/res/layout/test_activi ty.xml"/> | 426 <ignore regexp="content/shell/android/linker_test_apk/res/layout/test_activi ty.xml"/> |
| 427 <!-- TODO(crbug.com/635567): Fix this properly. --> | 427 <!-- TODO(crbug.com/635567): Fix this properly. --> |
| 428 <ignore regexp="content/shell/android/shell_apk/res/values/strings.xml"/> | 428 <ignore regexp="content/shell/android/shell_apk/res/values/strings.xml"/> |
| 429 </issue> | 429 </issue> |
| 430 <!-- TODO(crbug.com/669629): Remove this when the Chromecast dependency on old layout code is removed. --> | 430 <!-- TODO(crbug.com/669629): Remove this when the Chromecast dependency on old layout code is removed. --> |
| 431 <issue id="UseCompoundDrawables"> | 431 <issue id="UseCompoundDrawables"> |
| 432 <ignore regexp="chromecast/internal/android/prebuilt/settings/res/layout-v17 /setup_activity_progress.xml"/> | 432 <ignore regexp="chromecast/internal/android/prebuilt/settings/res/layout-v17 /setup_activity_progress.xml"/> |
| 433 </issue> | 433 </issue> |
| 434 <issue id="UselessParent"> | 434 <issue id="UselessParent"> |
| 435 <ignore regexp="android_webview/tools/system_webview_shell/apk/res/layout/ac tivity_webview_browser.xml"/> | 435 <ignore regexp="android_webview/tools/system_webview_shell/apk/res/layout/ac tivity_webview_browser.xml"/> |
| 436 <ignore regexp="chrome/android/java/res/layout/data_reduction_promo_screen.x ml"/> | 436 <ignore regexp="chrome/android/java/res/layout/data_reduction_promo_screen.x ml"/> |
|
pasko
2017/04/07 11:13:46
note: this file does not exist in the tree, remove
megjablon
2017/04/07 18:00:23
Done.
| |
| 437 <ignore regexp="chrome/android/java/res/layout/data_usage_breakdown.xml"/> | |
|
pasko
2017/04/07 11:13:46
I don't understand these suppressions and the reas
megjablon
2017/04/07 18:00:23
twellington took a look and commented previously.
pasko
2017/04/10 13:32:02
Thank you for explanation, I did not notice.
| |
| 437 <ignore regexp="chromecast/internal"/> | 438 <ignore regexp="chromecast/internal"/> |
| 438 <ignore regexp="tools/android/kerberos/SpnegoAuthenticator/res/layout/activi ty_account_authenticator.xml"/> | 439 <ignore regexp="tools/android/kerberos/SpnegoAuthenticator/res/layout/activi ty_account_authenticator.xml"/> |
| 439 </issue> | 440 </issue> |
| 440 <issue id="UsesMinSdkAttributes" severity="Error"> | 441 <issue id="UsesMinSdkAttributes" severity="Error"> |
| 441 <ignore regexp="AndroidManifest.xml"/> | 442 <ignore regexp="AndroidManifest.xml"/> |
| 442 </issue> | 443 </issue> |
| 443 <issue id="ValidFragment" severity="Error"> | 444 <issue id="ValidFragment" severity="Error"> |
| 444 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/media/ro uter/BaseMediaRouteDialogManager.java"/> | 445 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/media/ro uter/BaseMediaRouteDialogManager.java"/> |
| 445 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/media/ro uter/MediaRouteChooserDialogManager.java"/> | 446 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/media/ro uter/MediaRouteChooserDialogManager.java"/> |
| 446 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/media/ro uter/MediaRouteControllerDialogManager.java"/> | 447 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/media/ro uter/MediaRouteControllerDialogManager.java"/> |
| 447 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/preferen ces/privacy/OtherFormsOfHistoryDialogFragment.java"/> | 448 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/preferen ces/privacy/OtherFormsOfHistoryDialogFragment.java"/> |
| 448 <ignore regexp="media/capture/content/android/java/src/org/chromium/media/Sc reenCapture.java"/> | 449 <ignore regexp="media/capture/content/android/java/src/org/chromium/media/Sc reenCapture.java"/> |
| 449 </issue> | 450 </issue> |
| 450 <issue id="ViewConstructor" severity="ignore"/> | 451 <issue id="ViewConstructor" severity="ignore"/> |
| 451 <issue id="WrongCall" severity="ignore"/> | 452 <issue id="WrongCall" severity="ignore"/> |
| 452 <issue id="WrongConstant"> | 453 <issue id="WrongConstant"> |
| 453 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/SSLClien tCertificateRequest.java"/> | 454 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/SSLClien tCertificateRequest.java"/> |
| 454 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/payments /ui/EditorView.java"/> | 455 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/payments /ui/EditorView.java"/> |
| 455 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/signin/S igninAndSyncView.java"/> | 456 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/signin/S igninAndSyncView.java"/> |
| 456 <ignore regexp="content/public/android/java/src/org/chromium/content/browser /ChildProcessConnectionImpl.java"/> | 457 <ignore regexp="content/public/android/java/src/org/chromium/content/browser /ChildProcessConnectionImpl.java"/> |
| 457 </issue> | 458 </issue> |
| 458 </lint> | 459 </lint> |
| OLD | NEW |