Create a new Data Saver settings page that adds the site breakdown

chrome/browser/net/spdyproxy/data_reduction_proxy_settings_android.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_NET_SPDYPROXY_DATA_REDUCTION_PROXY_SETTINGS_ANDROID_H_
 #define CHROME_BROWSER_NET_SPDYPROXY_DATA_REDUCTION_PROXY_SETTINGS_ANDROID_H_
 
+#include <jni.h>
+
 #include <memory>
 
+#include "base/android/jni_android.h"
 #include "base/android/jni_string.h"
 #include "base/android/jni_weak_ref.h"
 #include "base/android/scoped_java_ref.h"
 #include "base/compiler_specific.h"
 #include "base/gtest_prod_util.h"
 #include "base/macros.h"
+#include "base/memory/weak_ptr.h"
+#include "components/data_reduction_proxy/proto/data_store.pb.h"
 #include "components/prefs/pref_member.h"
 
 using base::android::ScopedJavaLocalRef;
 
 class Profile;
 
 namespace data_reduction_proxy {
 class DataReductionProxySettings;
 }
 
 // Central point for configuring the data reduction proxy on Android.
 // This object lives on the UI thread and all of its methods are expected to
 // be called from there.
 class DataReductionProxySettingsAndroid {
  public:
+  // For testing purposes.

[sclittle, 2017/04/06 23:27:43]

nit: Is there some way this test-only constructor could be hidden such that only
tests would be able to access it?

[megjablon, 2017/04/07 01:20:03]

Friended the class and made it private

   DataReductionProxySettingsAndroid();
 
+  DataReductionProxySettingsAndroid(
+      JNIEnv* env,
+      const base::android::JavaParamRef<jobject>& obj);
+
   virtual ~DataReductionProxySettingsAndroid();
 
   void InitDataReductionProxySettings(Profile* profile);
 
   // JNI wrapper interfaces to the indentically-named superclass methods.
   jboolean IsDataReductionProxyPromoAllowed(
       JNIEnv* env,
       const base::android::JavaParamRef<jobject>& obj);
   jboolean IsDataReductionProxyEnabled(
       JNIEnv* env,
       const base::android::JavaParamRef<jobject>& obj);
   jboolean IsDataReductionProxyManaged(
       JNIEnv* env,
       const base::android::JavaParamRef<jobject>& obj);
   void SetDataReductionProxyEnabled(
       JNIEnv* env,
       const base::android::JavaParamRef<jobject>& obj,
       jboolean enabled);
   jlong GetDataReductionLastUpdateTime(
       JNIEnv* env,
       const base::android::JavaParamRef<jobject>& obj);
+  void ClearDataSavingStatistics(
+      JNIEnv* env,
+      const base::android::JavaParamRef<jobject>& obj);
   jlong GetTotalHttpContentLengthSaved(
         JNIEnv* env,
         const base::android::JavaParamRef<jobject>& obj);
   ScopedJavaLocalRef<jlongArray> GetDailyOriginalContentLengths(
       JNIEnv* env,
       const base::android::JavaParamRef<jobject>& obj);
   ScopedJavaLocalRef<jlongArray> GetDailyReceivedContentLengths(
       JNIEnv* env,
       const base::android::JavaParamRef<jobject>& obj);
 
@@ skipping 25 matching lines @@
   ScopedJavaLocalRef<jstring> GetHttpProxyList(
       JNIEnv* env,
       const base::android::JavaParamRef<jobject>& obj);
 
   // Returns a Java string of the last Data Reduction Proxy bypass event as
   // a JSON object.
   ScopedJavaLocalRef<jstring> GetLastBypassEvent(
       JNIEnv* env,
       const base::android::JavaParamRef<jobject>& obj);
 
+  // Gets the historical data usage for |numDays| and adds them to a list that
+  // groups data use by hostname.
+  void QueryDataUsage(JNIEnv* env,
+                      const base::android::JavaParamRef<jobject>& obj,
+                      const base::android::JavaParamRef<jobject>& j_result_obj,
+                      jint num_days);
+  void OnQueryDataUsageComplete(
+      std::unique_ptr<std::vector<data_reduction_proxy::DataUsageBucket>>

[sclittle, 2017/04/06 23:27:43]

Does this need to be a unique_ptr to a vector? Passing just a const
std::vector<DataUsageBucket>& seems like it would work just as well.

[megjablon, 2017/04/07 01:20:03]

That's the callback signature. That'll affect desktop so if we want to change
that, we should do that separately.

https://cs.chromium.org/chromium/src/components/data_reduction_proxy/core/bro...

+          data_usage);
+
   // Registers the native methods to be call from Java.
   static bool Register(JNIEnv* env);
 
+  base::android::ScopedJavaGlobalRef<jobject> j_settings_obj_;
+  base::android::ScopedJavaGlobalRef<jobject> j_query_result_obj_;
+  int num_day_for_query_;
+
  private:
   friend class DataReductionProxySettingsAndroidTest;
   FRIEND_TEST_ALL_PREFIXES(DataReductionProxySettingsAndroidTest,
                            TestGetDailyContentLengths);
 
   ScopedJavaLocalRef<jlongArray> GetDailyContentLengths(JNIEnv* env,
                                                         const char* pref_name);
 
   virtual data_reduction_proxy::DataReductionProxySettings* Settings();
 
+  base::WeakPtrFactory<DataReductionProxySettingsAndroid> weak_factory_;
+
   DISALLOW_COPY_AND_ASSIGN(DataReductionProxySettingsAndroid);
 };
 
 #endif  // CHROME_BROWSER_NET_SPDYPROXY_DATA_REDUCTION_PROXY_SETTINGS_ANDROID_H_