third_party/WebKit/Source/bindings/core/v8/ScriptModule.cpp - Issue 2781303002: [ES6 modules] Introduce ScriptModuleHash

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptModule.cpp

Issue 2781303002: [ES6 modules] Introduce ScriptModuleHash (Closed)

Patch Set: rebased Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/ScriptModule.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptModule.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptModule.cpp

index af36c3de58677f35ce528c4b78a050673fd9b618..fdd619dbc1a29322bef059c1c5afaca72d344cd9 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptModule.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptModule.cpp

@@ -11,7 +11,10 @@

namespace blink {

ScriptModule::ScriptModule(v8::Isolate* isolate, v8::Local<v8::Module> module)

- : m_module(SharedPersistent<v8::Module>::create(module, isolate)) {}

+ : m_module(SharedPersistent<v8::Module>::create(module, isolate)),

+ m_identityHash(static_cast<unsigned>(module->GetIdentityHash())) {

+ DCHECK(!m_module->isEmpty());

ScriptModule::~ScriptModule() {}