Issue 2781283003: VM: Re-enable regexp/global_test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2781283003: VM: Re-enable regexp/global_test (Closed)

Created:
3 years, 8 months ago by Florian Schneider

Modified:
3 years, 8 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

VM: Re-enable regexp/global_test The corresponding performance issue has been fixed. Fixes #21708. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/4525b2451cb617da9c69a36401bf067e902ea8ba

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	tests/corelib/corelib.status	View		1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 5 (2 generated)

Florian Schneider

This test now passes in <1s on x64, and <20s on debug-simarm.

3 years, 8 months ago (2017-03-30 22:58:34 UTC) #2

Florian Schneider

3 years, 8 months ago (2017-03-30 23:03:04 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
4525b2451cb617da9c69a36401bf067e902ea8ba (presubmit successful).