Chromium Code Reviews| Index: media/base/video_frame.h |
| diff --git a/media/base/video_frame.h b/media/base/video_frame.h |
| index 0ae2d706ca7e7a4fd4730d0fac5aa8d52f8e2050..ea4ab909c9681813c1e08888e77211fae50b4527 100644 |
| --- a/media/base/video_frame.h |
| +++ b/media/base/video_frame.h |
| @@ -63,8 +63,6 @@ class MEDIA_EXPORT VideoFrame : public base::RefCountedThreadSafe<VideoFrame> { |
| STORAGE_OWNED_MEMORY = 3, // VideoFrame has allocated its own data buffer. |
| STORAGE_SHMEM = 4, // Pixels are backed by Shared Memory. |
| #if defined(OS_LINUX) |
| - // TODO(mcasas): Consider turning this type into STORAGE_NATIVE or another |
| - // meaningful name and handle it appropriately in all cases. |
| STORAGE_DMABUFS = 5, // Each plane is stored into a DmaBuf. |
|
chfremer
2017/03/31 17:50:21
I chatted with mcasas@ and it seems that his sugge
Uzair
2017/04/03 04:17:40
Done.
|
| #endif |
| STORAGE_MOJO_SHARED_BUFFER = 6, |
| @@ -339,8 +337,7 @@ class MEDIA_EXPORT VideoFrame : public base::RefCountedThreadSafe<VideoFrame> { |
| #if defined(OS_LINUX) |
| // Returns backing DmaBuf file descriptor for given |plane|, if present, or |
| // -1 if not. |
| - // TODO(mcasas): Rename to DmabufFd() to comply with Style Guide. |
| - int dmabuf_fd(size_t plane) const; |
| + int DmabufFd(size_t plane) const; |
| // Duplicates internally the |fds_in|, overwriting the current ones. Returns |
| // false if something goes wrong, and leaves all internal fds closed. |
| @@ -351,8 +348,7 @@ class MEDIA_EXPORT VideoFrame : public base::RefCountedThreadSafe<VideoFrame> { |
| #if defined(OS_MACOSX) |
| // Returns the backing CVPixelBuffer, if present. |
| - // TODO(mcasas): Rename to CvPixelBuffer() to comply with Style Guide. |
| - CVPixelBufferRef cv_pixel_buffer() const; |
| + CVPixelBufferRef CvPixelBuffer() const; |
| #endif |
| // Sets the mailbox release callback. |