tools/metrics/histograms/histograms.xml - Issue 2781093002: Add attempt count metric to FaviconHandler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 2781093002: Add attempt count metric to FaviconHandler (Closed)

Patch Set: Readded a different metric for touch icons Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 1383139888c2b53bb63b7437a3000aa1e4c782a3..88c19cdeb9d845ad94a8a2fdd280aedb79360a24 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -20427,6 +20427,33 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</summary>

</histogram>

+<histogram name="Favicons.FaviconDownloadAttempts">

+ <owner>fhorschig@chromium.org</owner>

+ <summary>

+ Records the number of normal favicons requested until the best-fitting

+ candidate was found or there were no candidates left to check. The sum of

+ all Favicons.*DownloadAttempts captures all download attempts.

+ </summary>

+</histogram>

+<histogram name="Favicons.LargeIconDownloadAttempts">

+ <owner>fhorschig@chromium.org</owner>

+ <summary>

+ Records the number of icons requested until the largest, non-touch candidate

+ was found or there were no candidates left to check. The sum of all

+ Favicons.*DownloadAttempts captures all download attempts.

+ </summary>

+</histogram>

+<histogram name="Favicons.TouchIconDownloadAttempts">

+ <owner>fhorschig@chromium.org</owner>

+ <summary>

+ Records the number of icons requested until the largest, touch candidate was

+ found or there were no candidates left to check. The sum of all

+ Favicons.*DownloadAttempts captures all download attempts.

+ </summary>

+</histogram>

<histogram name="FileBrowser.CloudImport.UserAction"

enum="CloudImportUserAction">

<owner>smckay@google.com</owner>