Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Side by Side Diff: components/favicon/core/favicon_handler.h

Issue 2781093002: Add attempt count metric to FaviconHandler (Closed)
Patch Set: Verify expired results are recorded exactly once. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_FAVICON_CORE_FAVICON_HANDLER_H_ 5 #ifndef COMPONENTS_FAVICON_CORE_FAVICON_HANDLER_H_
6 #define COMPONENTS_FAVICON_CORE_FAVICON_HANDLER_H_ 6 #define COMPONENTS_FAVICON_CORE_FAVICON_HANDLER_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include <vector> 10 #include <vector>
(...skipping 272 matching lines...) Expand 10 before | Expand all | Expand 10 after
283 GURL notification_icon_url_; 283 GURL notification_icon_url_;
284 favicon_base::IconType notification_icon_type_; 284 favicon_base::IconType notification_icon_type_;
285 285
286 // The FaviconService which implements favicon operations. May be null during 286 // The FaviconService which implements favicon operations. May be null during
287 // testing. 287 // testing.
288 FaviconService* service_; 288 FaviconService* service_;
289 289
290 // This handler's delegate. 290 // This handler's delegate.
291 Delegate* delegate_; 291 Delegate* delegate_;
292 292
293 // Captures the number of download requests that were initiated for the
294 // current url_.
295 int num_download_requests_;
296
293 // The index of the favicon URL in |image_urls_| which is currently being 297 // The index of the favicon URL in |image_urls_| which is currently being
294 // requested from history or downloaded. 298 // requested from history or downloaded.
295 size_t current_candidate_index_; 299 size_t current_candidate_index_;
296 300
297 // Best image we've seen so far. As images are downloaded from the page they 301 // Best image we've seen so far. As images are downloaded from the page they
298 // are stored here. When a satisfying icon is found (as defined in 302 // are stored here. When a satisfying icon is found (as defined in
299 // UpdateFaviconCandidate()), the favicon service and the delegate are 303 // UpdateFaviconCandidate()), the favicon service and the delegate are
300 // notified. 304 // notified.
301 DownloadedFavicon best_favicon_; 305 DownloadedFavicon best_favicon_;
302 306
303 DISALLOW_COPY_AND_ASSIGN(FaviconHandler); 307 DISALLOW_COPY_AND_ASSIGN(FaviconHandler);
304 }; 308 };
305 309
306 } // namespace favicon 310 } // namespace favicon
307 311
308 #endif // COMPONENTS_FAVICON_CORE_FAVICON_HANDLER_H_ 312 #endif // COMPONENTS_FAVICON_CORE_FAVICON_HANDLER_H_
OLDNEW
« no previous file with comments | « no previous file | components/favicon/core/favicon_handler.cc » ('j') | components/favicon/core/favicon_handler.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698