Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Side by Side Diff: components/favicon/core/favicon_handler.h

Issue 2781093002: Add attempt count metric to FaviconHandler (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_FAVICON_CORE_FAVICON_HANDLER_H_ 5 #ifndef COMPONENTS_FAVICON_CORE_FAVICON_HANDLER_H_
6 #define COMPONENTS_FAVICON_CORE_FAVICON_HANDLER_H_ 6 #define COMPONENTS_FAVICON_CORE_FAVICON_HANDLER_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include <vector> 10 #include <vector>
(...skipping 263 matching lines...) Expand 10 before | Expand all | Expand 10 after
274 GURL notification_icon_url_; 274 GURL notification_icon_url_;
275 favicon_base::IconType notification_icon_type_; 275 favicon_base::IconType notification_icon_type_;
276 276
277 // The FaviconService which implements favicon operations. May be null during 277 // The FaviconService which implements favicon operations. May be null during
278 // testing. 278 // testing.
279 FaviconService* service_; 279 FaviconService* service_;
280 280
281 // This handler's delegate. 281 // This handler's delegate.
282 Delegate* delegate_; 282 Delegate* delegate_;
283 283
284 int request_attempts_;
285
284 // The index of the favicon URL in |image_urls_| which is currently being 286 // The index of the favicon URL in |image_urls_| which is currently being
285 // requested from history or downloaded. 287 // requested from history or downloaded.
286 size_t current_candidate_index_; 288 size_t current_candidate_index_;
287 289
288 // Best image we've seen so far. As images are downloaded from the page they 290 // Best image we've seen so far. As images are downloaded from the page they
289 // are stored here. When there is an exact match, or no more images are 291 // are stored here. When there is an exact match, or no more images are
290 // available the favicon service and the current page are updated (assuming 292 // available the favicon service and the current page are updated (assuming
291 // the image is for a favicon). 293 // the image is for a favicon).
292 FaviconCandidate best_favicon_candidate_; 294 FaviconCandidate best_favicon_candidate_;
293 295
294 DISALLOW_COPY_AND_ASSIGN(FaviconHandler); 296 DISALLOW_COPY_AND_ASSIGN(FaviconHandler);
295 }; 297 };
296 298
297 } // namespace favicon 299 } // namespace favicon
298 300
299 #endif // COMPONENTS_FAVICON_CORE_FAVICON_HANDLER_H_ 301 #endif // COMPONENTS_FAVICON_CORE_FAVICON_HANDLER_H_
OLDNEW
« no previous file with comments | « no previous file | components/favicon/core/favicon_handler.cc » ('j') | components/favicon/core/favicon_handler.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698