chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.h - Issue 2781083002: Fix the multi-threaded access to WeakPtr<BrowsingDataRemoverImpl>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.h

Issue 2781083002: Fix the multi-threaded access to WeakPtr<BrowsingDataRemoverImpl> (Closed)

Patch Set: Static method to local namespace. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/browsing_data/browsing_data_remover_impl.cc ('k') | chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.h

diff --git a/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.h b/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.h

index 17a19c465799981e4dd43f67f2c46b892f12a784..ef048e89e39b2eeb83ca76e47cd5fbb2b6e72fc3 100644

--- a/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.h

+++ b/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.h

@@ -173,10 +173,8 @@ class ChromeBrowsingDataRemoverDelegate : public BrowsingDataRemoverDelegate

~ChromeBrowsingDataRemoverDelegate() override;

// BrowsingDataRemoverDelegate:

- bool DoesOriginMatchEmbedderMask(

- int origin_type_mask,

- const GURL& origin,

- storage::SpecialStoragePolicy* special_storage_policy) const override;

+ BrowsingDataRemoverDelegate::EmbedderOriginTypeMatcher GetOriginTypeMatcher()

+ const override;

void RemoveEmbedderData(

const base::Time& delete_begin,

const base::Time& delete_end,