Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(833)

Unified Diff: chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.h

Issue 2781083002: Fix the multi-threaded access to WeakPtr<BrowsingDataRemoverImpl> (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.h
diff --git a/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.h b/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.h
index 17a19c465799981e4dd43f67f2c46b892f12a784..d96b5757c14f45b0e6ff6a7dc242f4a08ca91bae 100644
--- a/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.h
+++ b/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.h
@@ -173,10 +173,8 @@ class ChromeBrowsingDataRemoverDelegate : public BrowsingDataRemoverDelegate
~ChromeBrowsingDataRemoverDelegate() override;
// BrowsingDataRemoverDelegate:
- bool DoesOriginMatchEmbedderMask(
- int origin_type_mask,
- const GURL& origin,
- storage::SpecialStoragePolicy* special_storage_policy) const override;
+ BrowsingDataRemoverDelegate::MaskMatcherFunction GetMaskMatcherFunction()
+ const override;
void RemoveEmbedderData(
const base::Time& delete_begin,
const base::Time& delete_end,
@@ -197,6 +195,12 @@ class ChromeBrowsingDataRemoverDelegate : public BrowsingDataRemoverDelegate
#endif
private:
+ // Returned by GetMaskMatcherFunction().
+ static bool DoesOriginMatchEmbedderMask(
+ int origin_type_mask,
+ const GURL& origin,
+ storage::SpecialStoragePolicy* special_storage_policy);
+
// If AllDone(), calls the callback provided in RemoveEmbedderData().
void NotifyIfDone();

Powered by Google App Engine
This is Rietveld 408576698