Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: chrome/browser/browsing_data/mock_browsing_data_remover_delegate.cc

Issue 2781083002: Fix the multi-threaded access to WeakPtr<BrowsingDataRemoverImpl> (Closed)
Patch Set: Static method to local namespace. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/browsing_data/mock_browsing_data_remover_delegate.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/browsing_data/mock_browsing_data_remover_delegate.h" 5 #include "chrome/browser/browsing_data/mock_browsing_data_remover_delegate.h"
6 6
7 #include "base/callback.h" 7 #include "base/callback.h"
8 #include "content/public/browser/browsing_data_filter_builder.h" 8 #include "content/public/browser/browsing_data_filter_builder.h"
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 10
11 MockBrowsingDataRemoverDelegate::MockBrowsingDataRemoverDelegate() {} 11 MockBrowsingDataRemoverDelegate::MockBrowsingDataRemoverDelegate() {}
12 12
13 MockBrowsingDataRemoverDelegate::~MockBrowsingDataRemoverDelegate() { 13 MockBrowsingDataRemoverDelegate::~MockBrowsingDataRemoverDelegate() {
14 DCHECK(!expected_calls_.size()) << "Expectations were set but not verified."; 14 DCHECK(!expected_calls_.size()) << "Expectations were set but not verified.";
15 } 15 }
16 16
17 bool MockBrowsingDataRemoverDelegate::DoesOriginMatchEmbedderMask( 17 BrowsingDataRemoverDelegate::EmbedderOriginTypeMatcher
18 int origin_type_mask, 18 MockBrowsingDataRemoverDelegate::GetOriginTypeMatcher() const {
19 const GURL& origin, 19 return BrowsingDataRemoverDelegate::EmbedderOriginTypeMatcher();
20 storage::SpecialStoragePolicy* special_storage_policy) const {
21 return false;
22 } 20 }
23 21
24 void MockBrowsingDataRemoverDelegate::RemoveEmbedderData( 22 void MockBrowsingDataRemoverDelegate::RemoveEmbedderData(
25 const base::Time& delete_begin, 23 const base::Time& delete_begin,
26 const base::Time& delete_end, 24 const base::Time& delete_end,
27 int remove_mask, 25 int remove_mask,
28 const content::BrowsingDataFilterBuilder& filter_builder, 26 const content::BrowsingDataFilterBuilder& filter_builder,
29 int origin_type_mask, 27 int origin_type_mask,
30 const base::Closure& callback) { 28 const base::Closure& callback) {
31 actual_calls_.emplace_back(delete_begin, delete_end, remove_mask, 29 actual_calls_.emplace_back(delete_begin, delete_end, remove_mask,
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
87 if (a.delete_begin_ != b.delete_begin_ || a.delete_end_ != b.delete_end_ || 85 if (a.delete_begin_ != b.delete_begin_ || a.delete_end_ != b.delete_end_ ||
88 a.remove_mask_ != b.remove_mask_ || 86 a.remove_mask_ != b.remove_mask_ ||
89 a.origin_type_mask_ != b.origin_type_mask_) { 87 a.origin_type_mask_ != b.origin_type_mask_) {
90 return false; 88 return false;
91 } 89 }
92 90
93 if (!a.should_compare_filter_ || !b.should_compare_filter_) 91 if (!a.should_compare_filter_ || !b.should_compare_filter_)
94 return true; 92 return true;
95 return *a.filter_builder_ == *b.filter_builder_; 93 return *a.filter_builder_ == *b.filter_builder_;
96 } 94 }
OLDNEW
« no previous file with comments | « chrome/browser/browsing_data/mock_browsing_data_remover_delegate.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698