Added Mirror.UnlockAll with logic fixes.

Added Mirror.UnlockAll with logic fixes.

BUG=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=270205

[szager1, 2014-05-12 16:59:01]

ping

[Ryan Tseng, 2014-05-12 18:45:18]

lg after consolidating unlocking

https://codereview.chromium.org/278103002/diff/1/git_cache.py
File git_cache.py (right):

https://codereview.chromium.org/278103002/diff/1/git_cache.py#newcode367
git_cache.py:367: if (not dirent.endswith('.lock') or
opinion: I think the positive version looks more readable:
if (dirent.endswith('.lock') and os.path.isfile(os.path.join(cachepath,
dirent)):
  repo_dirs.add()

https://codereview.chromium.org/278103002/diff/1/git_cache.py#newcode375
git_cache.py:375: config_lock = os.path.join(repo_dir, 'config.lock')
Theres repeated code here.  Lets consolidate them.

[szager1, 2014-05-13 20:17:21]

https://codereview.chromium.org/278103002/diff/1/git_cache.py
File git_cache.py (right):

https://codereview.chromium.org/278103002/diff/1/git_cache.py#newcode367
git_cache.py:367: if (not dirent.endswith('.lock') or
On 2014/05/12 18:45:18, Ryan T. wrote:
> opinion: I think the positive version looks more readable:
> if (dirent.endswith('.lock') and os.path.isfile(os.path.join(cachepath,
> dirent)):
>   repo_dirs.add()

Done.

https://codereview.chromium.org/278103002/diff/1/git_cache.py#newcode375
git_cache.py:375: config_lock = os.path.join(repo_dir, 'config.lock')
On 2014/05/12 18:45:18, Ryan T. wrote:
> Theres repeated code here.  Lets consolidate them.

Done.

[Ryan Tseng, 2014-05-13 21:05:28]

https://codereview.chromium.org/278103002/diff/20001/git_cache.py
File git_cache.py (right):

https://codereview.chromium.org/278103002/diff/20001/git_cache.py#newcode156
git_cache.py:156: def FromPath(cls, path):
This looks like dead code, whats this for?

https://codereview.chromium.org/278103002/diff/20001/git_cache.py#newcode369
git_cache.py:369: for git_lock_file in ('config',):
Also "index"

[szager1, 2014-05-13 21:12:38]

https://codereview.chromium.org/278103002/diff/20001/git_cache.py
File git_cache.py (right):

https://codereview.chromium.org/278103002/diff/20001/git_cache.py#newcode156
git_cache.py:156: def FromPath(cls, path):
On 2014/05/13 21:05:28, Ryan T. wrote:
> This looks like dead code, whats this for?

It's actually new code, along with CacheDirToUrl().  I'm planning to use it
elsewhere.

https://codereview.chromium.org/278103002/diff/20001/git_cache.py#newcode369
git_cache.py:369: for git_lock_file in ('config',):
On 2014/05/13 21:05:28, Ryan T. wrote:
> Also "index"

That one is debatable, I think.  A left-over index.lock file frequently means
the repository is in a bad state.  Not sure we want to blithely delete that.

[Ryan Tseng, 2014-05-13 21:17:45]

lgtm

https://codereview.chromium.org/278103002/diff/20001/git_cache.py
File git_cache.py (right):

https://codereview.chromium.org/278103002/diff/20001/git_cache.py#newcode369
git_cache.py:369: for git_lock_file in ('config',):
On 2014/05/13 21:12:38, szager1 wrote:
> On 2014/05/13 21:05:28, Ryan T. wrote:
> > Also "index"
> 
> That one is debatable, I think.  A left-over index.lock file frequently means
> the repository is in a bad state.  Not sure we want to blithely delete that.

Fair enough.  I've see that a couple of times, but it might be the point where
we blow away the checkout if we see it though.

In that case, I think its a bit overkill to have a for loop of one item.

[szager1, 2014-05-13 21:24:34]

The CQ bit was checked by szager@chromium.org

[commit-bot: I haz the power, 2014-05-13 21:24:56]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/szager@chromium.org/278103002/40001

[commit-bot: I haz the power, 2014-05-13 21:27:50]

Change committed as 270205