third_party/WebKit/Source/core/loader/FrameLoader.cpp - Issue 2780953002: When historyEntryRequiresUserGesture is enabled, exempt docs that have been committed for 5 seconds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/FrameLoader.cpp

Issue 2780953002: When historyEntryRequiresUserGesture is enabled, exempt docs that have been committed for 5 seconds (Closed)

Patch Set: Address ojan's comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/loader/FrameLoader.cpp

diff --git a/third_party/WebKit/Source/core/loader/FrameLoader.cpp b/third_party/WebKit/Source/core/loader/FrameLoader.cpp

index 53f7684b8db3ea884fdd141dbc5b29bc0ca880a9..b8ffb5666b8eb4228c52bf7673b3e16f55ebf1d7 100644

--- a/third_party/WebKit/Source/core/loader/FrameLoader.cpp

+++ b/third_party/WebKit/Source/core/loader/FrameLoader.cpp

@@ -715,9 +715,8 @@ FrameLoadType FrameLoader::determineFrameLoadType(

m_documentLoader->loadType() == FrameLoadTypeReload)

return FrameLoadTypeReload;

- if (m_frame->settings()->getHistoryEntryRequiresUserGesture() &&

- request.originDocument() &&

- !request.originDocument()->frame()->hasReceivedUserGesture())

+ if (request.originDocument() &&

+ !request.originDocument()->canCreateHistoryEntry())

return FrameLoadTypeReplaceCurrentItem;

if (request.resourceRequest().url().isEmpty() &&

« no previous file with comments | « third_party/WebKit/Source/core/loader/DocumentLoader.cpp ('k') | no next file » | no next file with comments »