third_party/WebKit/LayoutTests/http/tests/history/history-entry-requires-user-gesture.html - Issue 2780953002: When historyEntryRequiresUserGesture is enabled, exempt docs that have been committed for 5 seconds

Unified Diff: third_party/WebKit/LayoutTests/http/tests/history/history-entry-requires-user-gesture.html

Issue 2780953002: When historyEntryRequiresUserGesture is enabled, exempt docs that have been committed for 5 seconds (Closed)

Patch Set: Centralize checking the setting Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/history/history-entry-requires-user-gesture-expected.txt » ('j') | third_party/WebKit/Source/core/dom/Document.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/history/history-entry-requires-user-gesture.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/history/history-entry-requires-user-gesture.html b/third_party/WebKit/LayoutTests/http/tests/history/history-entry-requires-user-gesture.html

new file mode 100644

index 0000000000000000000000000000000000000000..ca2e1333486209ebe2066339e23a0afb3a9fb099

--- /dev/null

+++ b/third_party/WebKit/LayoutTests/http/tests/history/history-entry-requires-user-gesture.html

@@ -0,0 +1,14 @@

+<body onload="loaded();">

ojan 2017/04/03 21:03:54 Should we also have a version of this test that ha

Nate Chapin 2017/04/04 20:42:19 Added a 2nd step to this test, so there's one navi

+<script>

+if (window.testRunner) {

+ testRunner.dumpAsText();

+ testRunner.dumpBackForwardList();

+ testRunner.waitUntilDone();

+ internals.settings.setHistoryEntryRequiresUserGesture(true);

ojan 2017/04/03 21:03:54 A downside of this solution is that we have to kee

Nate Chapin 2017/04/04 20:42:19 Time + churn. Giving them all a user gesture is a

Z_DONOTUSE 2017/04/05 17:39:13 Ah. That makes total sense. I wasn't thinking abou

+function loaded() {

+ setTimeout("location = '../resources/notify-done.html'", 0);

+</script>

+</body>