When historyEntryRequiresUserGesture is enabled, exempt docs that have been committed for 5 seconds

third_party/WebKit/Source/core/dom/Document.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2006 Alexey Proskuryakov (ap@webkit.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All
  * rights reserved.
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved.
  * (http://www.torchmobile.com/)
  * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
@@ skipping 3173 matching lines @@
   if (documentElement() && !isHTMLHtmlElement(*documentElement()))
     return true;
 
   return false;
 }
 
 int Document::elapsedTime() const {
   return static_cast<int>((currentTime() - m_startTime) * 1000);
 }
 
+bool Document::canCreateHistoryEntry() const {
+  if (!m_frame->settings()->getHistoryEntryRequiresUserGesture())
+    return true;
+  return elapsedTime() >= 5000 || m_frame->hasReceivedUserGesture();

[ojan, 2017/04/03 21:03:54]

I think you could test this as a SimTest that fast forwards the clock?

Also, can you move this time into a static constant so it can be more
self-documenting?

[Nate Chapin, 2017/04/04 20:42:19]

I could find ways to mess with last time of a compositing frame, but didn't
immediately see a way to fast forward currentTime()
Done.

+}
+
 void Document::write(const SegmentedString& text,
                      Document* enteredDocument,
                      ExceptionState& exceptionState) {
   if (importLoader()) {
     exceptionState.throwDOMException(
         InvalidStateError, "Imported document doesn't support write().");
     return;
   }
 
   if (!isHTMLDocument()) {
@@ skipping 3465 matching lines @@
 }
 
 void showLiveDocumentInstances() {
   WeakDocumentSet& set = liveDocumentSet();
   fprintf(stderr, "There are %u documents currently alive:\n", set.size());
   for (blink::Document* document : set)
     fprintf(stderr, "- Document %p URL: %s\n", document,
             document->url().getString().utf8().data());
 }
 #endif