Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3955)

Unified Diff: chrome/browser/safe_browsing/srt_fetcher_win.h

Issue 2780873002: Basic IPC communication between Chrome and the SW Reporter. (Closed)
Patch Set: RefCounted subclasses can't have public destructors Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/srt_fetcher_win.h
diff --git a/chrome/browser/safe_browsing/srt_fetcher_win.h b/chrome/browser/safe_browsing/srt_fetcher_win.h
index 32f0ee409a581ec289ac108044b7e3edde64324b..a6e79e1aecec608e1bc7af8e9cc6394d522fe37d 100644
--- a/chrome/browser/safe_browsing/srt_fetcher_win.h
+++ b/chrome/browser/safe_browsing/srt_fetcher_win.h
@@ -12,6 +12,9 @@
#include <string>
#include "base/command_line.h"
+#include "base/feature_list.h"
+#include "base/process/launch.h"
+#include "base/process/process.h"
#include "base/time/time.h"
namespace base {
@@ -44,6 +47,15 @@ const int kDaysBetweenSwReporterRunsForPendingPrompt = 1;
// The number of days to wait before sending out reporter logs.
const int kDaysBetweenReporterLogsSent = 7;
+// When enabled, moves all user interaction with the Software Reporter and the
+// Chrome Cleanup tool to Chrome.
+extern const base::Feature kInBrowserCleanerUIFeature;
+
+// The switch to be passed to the Software Reporter process with the Mojo pipe
+// token for the IPC communication with Chrome.
+// TODO(crbug/709035) Move this to //components/chrome_cleaner.
+extern const char kChromeMojoPipeTokenSwitch[];
+
// Parameters used to invoke the sw_reporter component.
struct SwReporterInvocation {
base::CommandLine command_line;
@@ -113,7 +125,9 @@ class SwReporterTestingDelegate {
virtual ~SwReporterTestingDelegate() {}
// Test mock for launching the reporter.
- virtual int LaunchReporter(const SwReporterInvocation& invocation) = 0;
+ virtual base::Process LaunchReporter(
+ const SwReporterInvocation& invocation,
+ const base::LaunchOptions& launch_options) = 0;
// Test mock for showing the prompt.
virtual void TriggerPrompt(Browser* browser,
« no previous file with comments | « chrome/browser/safe_browsing/srt_fetcher_browsertest_win.cc ('k') | chrome/browser/safe_browsing/srt_fetcher_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698