Improve TableView unit tests and fix bugs that were uncovered.

ui/views/controls/table/table_view_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/table/table_view.h"
 
 #include <stddef.h>
 
 #include "base/macros.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/events/event_utils.h"
+#include "ui/events/test/event_generator.h"
 #include "ui/views/controls/table/table_grouper.h"
 #include "ui/views/controls/table/table_header.h"
 #include "ui/views/controls/table/table_view_observer.h"
+#include "ui/views/test/views_test_base.h"
 
 // Put the tests in the views namespace to make it easier to declare them as
 // friend classes.
 namespace views {
 
 class TableViewTestHelper {
  public:
   explicit TableViewTestHelper(TableView* table) : table_(table) {}
 
   std::string GetPaintRegion(const gfx::Rect& bounds) {
     TableView::PaintRegion region(table_->GetPaintRegion(bounds));
     return "rows=" + base::IntToString(region.min_row) + " " +
         base::IntToString(region.max_row) + " cols=" +
         base::IntToString(region.min_column) + " " +
         base::IntToString(region.max_column);
   }
 
   size_t visible_col_count() {
     return table_->visible_columns().size();
   }
 
   TableHeader* header() { return table_->header_; }
 
   void SetSelectionModel(const ui::ListSelectionModel& new_selection) {
     table_->SetSelectionModel(new_selection);
   }
 
-  void OnFocus() {
-    table_->OnFocus();
-  }
-
  private:
   TableView* table_;
 
   DISALLOW_COPY_AND_ASSIGN(TableViewTestHelper);
 };
 
 namespace {
 
 // TestTableModel2 -------------------------------------------------------------
 
@@ skipping 119 matching lines @@
         result += ", ";  // Comma between each value in the row.
 
       result += base::UTF16ToUTF8(
           table->model()->GetText(table->ViewToModel(i), column.id));
     }
     result += "]";
   }
   return result;
 }
 
-class TestTableView : public TableView {
- public:
-  TestTableView(ui::TableModel* model,
-                const std::vector<ui::TableColumn>& columns)
-      : TableView(model, columns, TEXT_ONLY, false) {
-  }
-
-  // View overrides:
-  bool HasFocus() const override {
-    // Overriden so key processing works.
-    return true;
-  }
-
- private:
-  DISALLOW_COPY_AND_ASSIGN(TestTableView);
-};
-
 }  // namespace
 
-class TableViewTest : public testing::Test {
+class TableViewTest : public ViewsTestBase {
  public:
   TableViewTest() : table_(NULL) {}
 
   void SetUp() override {
+    ViewsTestBase::SetUp();
+
     model_.reset(new TestTableModel2);
     std::vector<ui::TableColumn> columns(2);
     columns[0].title = base::ASCIIToUTF16("Title Column 0");
     columns[0].sortable = true;
     columns[1].title = base::ASCIIToUTF16("Title Column 1");
     columns[1].id = 1;
     columns[1].sortable = true;
-    table_ = new TestTableView(model_.get(), columns);
-    parent_.reset(table_->CreateParentIfNecessary());
-    parent_->SetBounds(0, 0, 10000, 10000);
-    parent_->Layout();
+    table_ = new TableView(model_.get(), columns, TEXT_ONLY, false);
+    View* parent = table_->CreateParentIfNecessary();
+    parent->SetBounds(0, 0, 10000, 10000);
+    parent->Layout();
     helper_.reset(new TableViewTestHelper(table_));
+
+    Widget::InitParams params = CreateParams(Widget::InitParams::TYPE_WINDOW);
+    params.ownership = views::Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;
+    params.bounds = gfx::Rect(0, 0, 650, 650);

[tapted, 2017/04/04 00:07:36]

Offsetting the (x,y) coordinate here might resolve the issues. E.g. use (100,
100, 650, 650); (but that might throw off coordinates elsewhere in the tests).

Alternatively, I think Widget::InitParams::TYPE_WINDOW_FRAMELESS above will work
too (perhaps better, but changing the Widget type can have other effects around
activation and things).

On Mac, when you Show() a real Widget (with a titlebar, etc.) at (0,0), the
window manager moves it into the work area (below menu bar, or possibly a Dock
hugging the left of the screen). Anticipating the move, or using a window type
that the window manager doesn't move should work around that.

If you're still stuck, I might have a chance later to look into it more.. I
should be able to detect this situation in the event generator and warn about it
too.. (sadly auto-correcting for it turned out to be a dead-end since tests
sometimes do and sometimes don't convert from root window coordinates to Widget
coordinates -- so some tests will break if we auto-correct).

+    widget_.reset(new Widget);
+    widget_->Init(params);
+    widget_->GetContentsView()->AddChildView(parent);
+    widget_->Show();
+  }
+
+  void TearDown() override {
+    widget_.reset();
+    ViewsTestBase::TearDown();
   }
 
   void ClickOnRow(int row, int flags) {
-    const int y = row * table_->row_height();
-    const ui::MouseEvent pressed(ui::ET_MOUSE_PRESSED, gfx::Point(0, y),
-                                 gfx::Point(0, y), ui::EventTimeForNow(),
-                                 ui::EF_LEFT_MOUSE_BUTTON | flags,
-                                 ui::EF_LEFT_MOUSE_BUTTON);
-    table_->OnMousePressed(pressed);
+    ui::test::EventGenerator generator(widget_->GetNativeWindow());
+    generator.set_flags(flags);
+    generator.set_current_location(GetPointForRow(row));
+    generator.PressLeftButton();
   }
 
   void TapOnRow(int row) {
-    const int y = row * table_->row_height();
-    const ui::GestureEventDetails event_details(ui::ET_GESTURE_TAP);
-    ui::GestureEvent tap(0, y, 0, base::TimeTicks(), event_details);
-    table_->OnGestureEvent(&tap);
+    ui::test::EventGenerator generator(widget_->GetNativeWindow());
+    generator.GestureTapAt(GetPointForRow(row));
   }
 
   // Returns the state of the selection model as a string. The format is:
   // 'active=X anchor=X selection=X X X...'.
   std::string SelectionStateAsString() const {
     const ui::ListSelectionModel& model(table_->selection_model());
     std::string result = "active=" + base::IntToString(model.active()) +
         " anchor=" + base::IntToString(model.anchor()) +
         " selection=";
     const ui::ListSelectionModel::SelectedIndices& selection(
         model.selected_indices());
     for (size_t i = 0; i < selection.size(); ++i) {
       if (i != 0)
         result += " ";
       result += base::IntToString(selection[i]);
     }
     return result;
   }
 
   void PressKey(ui::KeyboardCode code) {
-    ui::KeyEvent event(ui::ET_KEY_PRESSED, code, ui::EF_NONE);
-    table_->OnKeyPressed(event);
+    ui::test::EventGenerator generator(widget_->GetNativeWindow());
+    generator.PressKey(code, ui::EF_NONE);
   }
 
  protected:
   std::unique_ptr<TestTableModel2> model_;
 
   // Owned by |parent_|.
   TableView* table_;
 
   std::unique_ptr<TableViewTestHelper> helper_;
 
  private:
-  std::unique_ptr<View> parent_;
+  gfx::Point GetPointForRow(int row) {
+    const int y = (row + 0.5) * table_->row_height();
+    return table_->GetBoundsInScreen().origin() + gfx::Vector2d(5, y);
+  }
+
+  std::unique_ptr<Widget> widget_;
 
   DISALLOW_COPY_AND_ASSIGN(TableViewTest);
 };
 
 // Verifies GetPaintRegion.
 TEST_F(TableViewTest, GetPaintRegion) {
   // Two columns should be visible.
   EXPECT_EQ(2u, helper_->visible_col_count());
 
   EXPECT_EQ("rows=0 4 cols=0 2", helper_->GetPaintRegion(table_->bounds()));
@@ skipping 445 matching lines @@
 }
 
 // Verifies selection works by way of a gesture.
 TEST_F(TableViewTest, SelectOnTap) {
   // Initially no selection.
   EXPECT_EQ("active=-1 anchor=-1 selection=", SelectionStateAsString());
 
   TableViewObserverImpl observer;
   table_->set_observer(&observer);
 
-  // Click on the first row, should select it.
+  // Tap on the first row, should select it.
   TapOnRow(0);
   EXPECT_EQ(1, observer.GetChangedCountAndClear());
   EXPECT_EQ("active=0 anchor=0 selection=0", SelectionStateAsString());
 
   table_->set_observer(NULL);
 }
 
 // Verifies up/down correctly navigates through groups.
 TEST_F(TableViewTest, KeyUpDown) {
   // Configure the grouper so that there are three groups:
   // A 0
   //   1
   // B 5
   // C 2
   //   3
   model_->AddRow(2, 5, 0);
   TableGrouperImpl grouper;
   std::vector<int> ranges;
   ranges.push_back(2);
   ranges.push_back(1);
   ranges.push_back(2);
   grouper.SetRanges(ranges);
   table_->SetGrouper(&grouper);
 
   TableViewObserverImpl observer;
   table_->set_observer(&observer);
+  table_->RequestFocus();
 
   // Initially no selection.
   EXPECT_EQ("active=-1 anchor=-1 selection=", SelectionStateAsString());
 
   PressKey(ui::VKEY_DOWN);
   EXPECT_EQ(1, observer.GetChangedCountAndClear());
   EXPECT_EQ("active=0 anchor=0 selection=0 1", SelectionStateAsString());
 
   PressKey(ui::VKEY_DOWN);
   EXPECT_EQ(1, observer.GetChangedCountAndClear());
@@ skipping 110 matching lines @@
   TableGrouperImpl grouper;
   std::vector<int> ranges;
   ranges.push_back(2);
   ranges.push_back(1);
   ranges.push_back(2);
   grouper.SetRanges(ranges);
   table_->SetGrouper(&grouper);
 
   TableViewObserverImpl observer;
   table_->set_observer(&observer);
+  table_->RequestFocus();
 
   // Initially no selection.
   EXPECT_EQ("active=-1 anchor=-1 selection=", SelectionStateAsString());
 
   PressKey(ui::VKEY_HOME);
   EXPECT_EQ(1, observer.GetChangedCountAndClear());
   EXPECT_EQ("active=0 anchor=0 selection=0 1", SelectionStateAsString());
 
   PressKey(ui::VKEY_END);
   EXPECT_EQ(1, observer.GetChangedCountAndClear());
   EXPECT_EQ("active=4 anchor=4 selection=3 4", SelectionStateAsString());
 
+  PressKey(ui::VKEY_HOME);
+  EXPECT_EQ(1, observer.GetChangedCountAndClear());
+  EXPECT_EQ("active=0 anchor=0 selection=0 1", SelectionStateAsString());
+
   table_->set_observer(NULL);
 }
 
 // Verifies multiple selection gestures work (control-click, shift-click ...).
 TEST_F(TableViewTest, Multiselection) {
   // Configure the grouper so that there are three groups:
   // A 0
   //   1
   // B 5
   // C 2
@@ skipping 96 matching lines @@
 TEST_F(TableViewTest, FocusAfterRemovingAnchor) {
   table_->ToggleSortOrder(0);
 
   ui::ListSelectionModel new_selection;
   new_selection.AddIndexToSelection(0);
   new_selection.AddIndexToSelection(1);
   new_selection.set_active(0);
   new_selection.set_anchor(0);
   helper_->SetSelectionModel(new_selection);
   model_->RemoveRow(0);
-  helper_->OnFocus();
-}
-
-// Tests that focusing the table will activate the first row, but only if
-// there's no active row.
-TEST_F(TableViewTest, InitialFocusActivatesFirstRow) {
-  EXPECT_EQ(-1, table_->selection_model().active());
-  helper_->OnFocus();
-  EXPECT_EQ(0, table_->selection_model().active());
-
-  ui::ListSelectionModel new_selection;
-  new_selection.set_active(1);
-  helper_->SetSelectionModel(new_selection);
-  EXPECT_EQ(1, table_->selection_model().active());
-  helper_->OnFocus();
-  EXPECT_EQ(1, table_->selection_model().active());
-
-  // Remove all rows; focusing should not activate a non existent first row.
-  while (model_->RowCount())
-    model_->RemoveRow(0);
-
-  new_selection.set_active(-1);
-  helper_->SetSelectionModel(new_selection);
-  helper_->OnFocus();
-  EXPECT_EQ(-1, table_->selection_model().active());
+  table_->RequestFocus();
 }
 
 }  // namespace views