Improve TableView unit tests and fix bugs that were uncovered.

ui/views/controls/table/table_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/table/table_view.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <map>
 #include <utility>
 
 #include "base/auto_reset.h"
 #include "base/i18n/rtl.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
+#include "base/threading/thread_task_runner_handle.h"
 #include "cc/paint/paint_flags.h"
 #include "ui/accessibility/ax_node_data.h"
 #include "ui/events/event.h"
 #include "ui/gfx/canvas.h"
 #include "ui/gfx/geometry/rect_conversions.h"
 #include "ui/gfx/image/image_skia.h"
 #include "ui/gfx/skia_util.h"
 #include "ui/gfx/text_utils.h"
 #include "ui/native_theme/native_theme.h"
 #include "ui/views/controls/scroll_view.h"
@@ skipping 106 matching lines @@
       columns_(columns),
       header_(NULL),
       table_type_(table_type),
       single_selection_(single_selection),
       select_on_remove_(true),
       observer_(NULL),
       row_height_(font_list_.GetHeight() + kTextVerticalPadding * 2),
       last_parent_width_(0),
       layout_width_(0),
       grouper_(NULL),
-      in_set_visible_column_width_(false) {
+      in_set_visible_column_width_(false),
+      weak_factory_(this) {
   for (size_t i = 0; i < columns.size(); ++i) {
     VisibleColumn visible_column;
     visible_column.column = columns[i];
     visible_columns_.push_back(visible_column);
   }
   // Always focusable, even on Mac (consistent with NSTableView).
   SetFocusBehavior(FocusBehavior::ALWAYS);
   SetModel(model);
 }
 
@@ skipping 464 matching lines @@
         kGroupingIndicatorSize / 2, grouping_flags);
     i = last + 1;
   }
 }
 
 void TableView::OnFocus() {
   ScrollView* scroll_view = ScrollView::GetScrollViewForContents(this);
   if (scroll_view)
     scroll_view->SetHasFocusIndicator(true);
 
-  if (selection_model_.active() == -1 && RowCount())
-    SelectByViewIndex(0);
+  base::ThreadTaskRunnerHandle::Get()->PostTask(

[sky, 2017/03/30 03:25:49]

We shouldn't need to delay this. The press handler can change the selection,
then request focus if it needs to.

+      FROM_HERE, base::Bind(&TableView::SelectFirstRowIfNoneSelected,
+                            weak_factory_.GetWeakPtr()));
 
   SchedulePaintForSelection();
   NotifyAccessibilityEvent(ui::AX_EVENT_FOCUS, true);
 }
 
 void TableView::OnBlur() {
   ScrollView* scroll_view = ScrollView::GetScrollViewForContents(this);
   if (scroll_view)
     scroll_view->SetHasFocusIndicator(false);
   SchedulePaintForSelection();
@@ skipping 309 matching lines @@
 
   if (tooltip)
     *tooltip = text;
   if (tooltip_origin) {
     tooltip_origin->SetPoint(cell_bounds.x(),
                              cell_bounds.y() + kTextVerticalPadding);
   }
   return true;
 }
 
+void TableView::SelectFirstRowIfNoneSelected() {
+  if (HasFocus() && selection_model_.active() == -1 && RowCount())
+    SelectByViewIndex(0);
+}
+
 }  // namespace views