Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 2780833002: Add ParserErrorCode.INVALID_CONSTRUCTOR_NAME to the list of all error codes. (Closed)

Created:
3 years, 8 months ago by scheglov
Modified:
3 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add ParserErrorCode.INVALID_CONSTRUCTOR_NAME to the list of all error codes. We need this for AnalysisDriver to be able to deserialize this error. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/9b701ae3da970c4ad9de2d08fa9ea6d42913c8ee

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M pkg/analyzer/lib/error/error.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 8 months ago (2017-03-28 16:51:06 UTC) #1
Brian Wilkerson
lgtm
3 years, 8 months ago (2017-03-28 17:20:09 UTC) #2
scheglov
3 years, 8 months ago (2017-03-28 17:31:07 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9b701ae3da970c4ad9de2d08fa9ea6d42913c8ee (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698