Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 2780823003: Fix -Wshift-negative-value warnings with MAKE_PROCESS_CPUCLOCK. (Closed)

Created:
3 years, 8 months ago by Nico
Modified:
3 years, 8 months ago
Reviewers:
Mark Seaborn
CC:
chromium-reviews, Markus (顧孟勤)
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix -Wshift-negative-value warnings with MAKE_PROCESS_CPUCLOCK. Left-shifting a sign bit has undefined behavior. BUG=chromium:507717 R=mseaborn@chromium.org Committed: https://chromium.googlesource.com/linux-syscall-support/+/a2b70922e631af748fad9265e58ec3c3414d77a3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M linux_syscall_support.h View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Nico
3 years, 8 months ago (2017-03-28 21:49:20 UTC) #2
Mark Seaborn
LGTM
3 years, 8 months ago (2017-03-28 22:03:12 UTC) #3
Nico
Thanks! Do I have commit permissions? If not, can you land this? On Mar 28, ...
3 years, 8 months ago (2017-03-28 22:09:19 UTC) #4
Mark Seaborn
On 2017/03/28 22:09:19, Nico wrote: > Thanks! Do I have commit permissions? If not, can ...
3 years, 8 months ago (2017-03-28 22:17:00 UTC) #5
Nico
3 years, 8 months ago (2017-03-30 15:03:41 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a2b70922e631af748fad9265e58ec3c3414d77a3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698