Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Unified Diff: components/ntp_snippets/reading_list/reading_list_suggestions_provider.cc

Issue 2780793002: Add extra information for ReadingList ContentSuggestion (Closed)
Patch Set: Address comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/ntp_snippets/reading_list/reading_list_suggestions_provider.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/ntp_snippets/reading_list/reading_list_suggestions_provider.cc
diff --git a/components/ntp_snippets/reading_list/reading_list_suggestions_provider.cc b/components/ntp_snippets/reading_list/reading_list_suggestions_provider.cc
index 5dbcbe660098db6be08f880ee7203d9bfc9c9e14..d6366ef811e77df3bbb9d908d1526a613b7ceeb0 100644
--- a/components/ntp_snippets/reading_list/reading_list_suggestions_provider.cc
+++ b/components/ntp_snippets/reading_list/reading_list_suggestions_provider.cc
@@ -8,9 +8,11 @@
#include <vector>
#include "base/bind.h"
+#include "base/memory/ptr_util.h"
#include "base/strings/utf_string_conversions.h"
#include "base/threading/thread_task_runner_handle.h"
#include "components/ntp_snippets/category.h"
+#include "components/ntp_snippets/reading_list/reading_list_distillation_state_util.h"
#include "components/reading_list/core/reading_list_entry.h"
#include "components/reading_list/core/reading_list_model.h"
#include "components/strings/grit/components_strings.h"
@@ -149,17 +151,7 @@ void ReadingListSuggestionsProvider::FetchReadingListInternal() {
std::vector<ContentSuggestion> suggestions;
for (const ReadingListEntry* entry : entries) {
- ContentSuggestion suggestion(provided_category_, entry->URL().spec(),
- entry->URL());
-
- if (!entry->Title().empty()) {
- suggestion.set_title(base::UTF8ToUTF16(entry->Title()));
- } else {
- suggestion.set_title(url_formatter::FormatUrl(entry->URL()));
- }
- suggestion.set_publisher_name(
- url_formatter::FormatUrl(entry->URL().GetOrigin()));
- suggestions.emplace_back(std::move(suggestion));
+ suggestions.emplace_back(ConvertEntry(entry));
}
NotifyStatusChanged(CategoryStatus::AVAILABLE);
@@ -167,6 +159,29 @@ void ReadingListSuggestionsProvider::FetchReadingListInternal() {
std::move(suggestions));
}
+ContentSuggestion ReadingListSuggestionsProvider::ConvertEntry(
+ const ReadingListEntry* entry) {
+ ContentSuggestion suggestion(provided_category_, entry->URL().spec(),
+ entry->URL());
+
+ if (!entry->Title().empty()) {
+ suggestion.set_title(base::UTF8ToUTF16(entry->Title()));
+ } else {
+ suggestion.set_title(url_formatter::FormatUrl(entry->URL()));
+ }
+ suggestion.set_publisher_name(
+ url_formatter::FormatUrl(entry->URL().GetOrigin()));
+
+ auto extra = base::MakeUnique<ReadingListSuggestionExtra>();
+ extra->distilled_state =
+ SuggestionStateFromReadingListState(entry->DistilledState());
+ extra->favicon_page_url =
+ entry->DistilledURL().is_valid() ? entry->DistilledURL() : entry->URL();
+ suggestion.set_reading_list_suggestion_extra(std::move(extra));
+
+ return suggestion;
+}
+
void ReadingListSuggestionsProvider::NotifyStatusChanged(
CategoryStatus new_status) {
if (category_status_ == new_status) {
« no previous file with comments | « components/ntp_snippets/reading_list/reading_list_suggestions_provider.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698