Add extra information for ReadingList ContentSuggestion

components/ntp_snippets/content_suggestion.h

Index: components/ntp_snippets/content_suggestion.h
diff --git a/components/ntp_snippets/content_suggestion.h b/components/ntp_snippets/content_suggestion.h
index b2403f6c749ef97c3245abbaba77e7288dd6e952..cc523024b759c83c6368047eb4478f33bda5dd2f 100644
--- a/components/ntp_snippets/content_suggestion.h
+++ b/components/ntp_snippets/content_suggestion.h
@@ -17,6 +17,22 @@
 
 namespace ntp_snippets {
 
+// ReadingListSuggestionExtra contains addition data which is only available for

[Marc Treib, 2017/03/28 13:38:20]

nit: s/addition/additional/

nit: Keep the order consistent with the setters, i.e. move this below
RecentTabSuggestionExtra

[gambard, 2017/03/29 06:51:24]

Done.

+// Reading List suggestions.
+struct ReadingListSuggestionExtra {
+  // State of the distillation a suggestion.

[Olivier, 2017/03/28 13:43:45]

Whi not use ReadingListEntry::DistillationState ?
At least, add a comment saying enums should stay synced.

[gambard, 2017/03/29 06:51:24]

I am not using ReadingListEntry::DistillationState directly because we want to
remove the dependence of components/ntp_snippets on components/reading_list

+  enum class ReadingListSuggestionDistilledState {
+    PROCESSING,
+    SUCCESS,
+    FAILURE
+  };
+
+  // State of the distillation of the suggestion.
+  ReadingListSuggestionDistilledState distilled_state;
+  // URL of the page whose favicon should be displayed for this suggestion.
+  GURL favicon_page_url;

[Marc Treib, 2017/03/28 13:38:20]

Can't this be derived from the URL?
Generally, +jkrcal for favicons, since various things are in progress there.

[gambard, 2017/03/29 06:51:24]

No, this is specific to ReadingList: you can have an entry with the url
chromium.org but there is a redirection to foo.bar, the distillation (= download
for offline availability) ends up at foo.bar. The favicon_page_url will be
foo.bar to display the favicon relative to the final page.
The favicon fetching is done through the standard favicon fetcher component.

[Marc Treib, 2017/03/29 08:24:58]

Redirects are officially The Worst :(
Alright then, though I'd still like to get a sanity check from jkrcal, since I'm
not familiar with the latest state on favicons.

+};
+
 // DownloadSuggestionExtra contains additional data which is only available for
 // download suggestions.
 struct DownloadSuggestionExtra {
@@ -144,6 +160,15 @@ class ContentSuggestion {
   void set_recent_tab_suggestion_extra(
       std::unique_ptr<RecentTabSuggestionExtra> recent_tab_suggestion_extra);
 
+  // Extra information for reading list suggestions. Only available for
+  // KnownCategories::READING_LIST suggestions.
+  ReadingListSuggestionExtra* reading_list_suggestion_extra() const {
+    return reading_list_suggestion_extra_.get();
+  }
+  void set_reading_list_suggestion_extra(
+      std::unique_ptr<ReadingListSuggestionExtra>
+          reading_list_suggestion_extra);
+
   // Extra information for notifications. When absent, no notification should be
   // sent for this suggestion. When present, a notification should be sent,
   // unless other factors disallow it (examples: the extra parameters say to;
@@ -169,6 +194,7 @@ class ContentSuggestion {
   float score_;
   std::unique_ptr<DownloadSuggestionExtra> download_suggestion_extra_;
   std::unique_ptr<RecentTabSuggestionExtra> recent_tab_suggestion_extra_;
+  std::unique_ptr<ReadingListSuggestionExtra> reading_list_suggestion_extra_;
   std::unique_ptr<NotificationExtra> notification_extra_;
 
   // The time when the remote suggestion was fetched from the server. This field